From: Eric Blake <eblake@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com,
qemu-devel@nongnu.org, anthony@codemonkey.ws,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callouts on raw devices
Date: Wed, 02 Oct 2013 09:08:04 -0600 [thread overview]
Message-ID: <524C36D4.80608@redhat.com> (raw)
In-Reply-To: <1380723636-18456-1-git-send-email-pl@kamp.de>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
On 10/02/2013 08:20 AM, Peter Lieven wrote:
> if a raw device like an iscsi target or host device is used
> the current implementation makes a second call out to get
> the block status of bs->file. however, the raw driver already
> has called bdrv_get_block_status on bs->file.
>
> v4: use a flag to detect the raw driver instead of the strncmp
> hack.
The v4 designation...
>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
...should appear after the --- separator (useful to reviewers, but
doesn't need to be part of the git history).
> block.c | 4 ++--
> block/raw_bsd.c | 6 +++++-
> include/block/block.h | 3 +++
> 3 files changed, 10 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
prev parent reply other threads:[~2013-10-02 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 14:20 [Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callouts on raw devices Peter Lieven
2013-10-02 15:06 ` Stefan Hajnoczi
2013-10-02 15:13 ` Paolo Bonzini
2013-10-02 15:34 ` Peter Lieven
2013-10-02 16:02 ` Peter Lieven
2013-10-02 15:08 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524C36D4.80608@redhat.com \
--to=eblake@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.