From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQV8-0008Qf-2P for qemu-devel@nongnu.org; Wed, 02 Oct 2013 13:46:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRQV1-0006Gb-VZ for qemu-devel@nongnu.org; Wed, 02 Oct 2013 13:46:17 -0400 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:41572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQV1-0006GR-Ox for qemu-devel@nongnu.org; Wed, 02 Oct 2013 13:46:11 -0400 Message-ID: <524C5BDE.1090104@weilnetz.de> Date: Wed, 02 Oct 2013 19:46:06 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1380709396-6063-1-git-send-email-ottlik@fzi.de> <524C118A.90106@redhat.com> In-Reply-To: <524C118A.90106@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 0/5] Do not set SO_REUSEADDR on Windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Sebastian Ottlik Cc: Jan Kiszka , Stefan Hajnoczi , qemu-devel@nongnu.org, Anthony Liguori Am 02.10.2013 14:28, schrieb Eric Blake: > On 10/02/2013 04:23 AM, Sebastian Ottlik wrote: >> This patchset disables most uses of SO_REUSEADDR on Windows and replaces it with >> calls to the new function socket_set_fast_reuse. On Windows systems the default >> behaviour is equivalent to SO_REUSEADDR on other operating systems. SO_REUSEADDR >> can still be set but results in undesired behaviour in most cases. It may even >> lead to situations were system behaviour is unspecified. More information on >> this can be found at: >> http://msdn.microsoft.com/en-us/library/windows/desktop/ms740621.aspx >> >> I originally encountered this issue when accidentally launching two QEMU >> instances with identical GDB ports at the same time. In which case QEMU won't >> fail as one might expect. >> >> Note that patch #4 fails checkpatch.pl. This is intentional (see v3 changes). >> >> v6 Changes: >> - dropped error output and the silent parameter in favor of an assertion >> >> Actually I wanted to remove the return value from the function too, as the >> assertion pretty much states that the function will not fail and thus always >> return 0. However this would make the code a little ugly to prevent unused >> variable warnings if NDEBUG is set (see patch 1) and also would require some >> ugly changes to slirp/socket.c (see patch 4). Thus I decided to keep it. >> >> - Rebased to current master (a684f3cf9b9b9c3cb82be87aafc463de8974610c) >> > > Series: Reviewed-by: Eric Blake Thanks for the patches and for the review. I applied all to my mingw patch queue and have sent a pull request. Stefan