From: Hans Verkuil <hverkuil@xs4all.nl>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devel@driverdev.osuosl.org, linux-media@vger.kernel.org,
Sergio Aguirre <sergio.a.aguirre@gmail.com>,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: [PATCH 0/6] OMAP4 ISS driver
Date: Thu, 03 Oct 2013 09:00:07 +0200 [thread overview]
Message-ID: <524D15F7.5070102@xs4all.nl> (raw)
In-Reply-To: <1380758133-16866-1-git-send-email-laurent.pinchart@ideasonboard.com>
Hi Laurent,
On 10/03/2013 01:55 AM, Laurent Pinchart wrote:
> Hello,
>
> The OMAP4 ISS driver has lived out of tree for more than two years now. This
> situation is both sad and resource-wasting, as the driver has been used (and
> thus) hacked since then with nowhere to send patches to. Time has come to fix
> the problem.
>
> As the code is mostly, but not quite ready for prime time, I'd like to request
> its addition to drivers/staging/. I've added a (pretty small) TODO file and I
> commit to cleaning up the code and get it to drivers/media/ where it belongs.
>
> I've split the driver in six patches to avoid getting caught in vger's size
> and to make review slightly easier. Sergio Aguirre is the driver author (huge
> thanks for that!), I've thus kept his authorship on patches 1/6 to 5/6.
>
> I don't have much else to add here, let's get this beast to mainline and allow
> other developers to use the driver and contribute patches.
Thanks for the patch series! Much appreciated.
For this patch series:
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
I've posted a few comments for the first two patches (nothing jumped out to me for
the other patches) that you may want to address in a follow-up patch, particularly
the missing timestamp_type for vb2_queue will give a lot of WARN_ON messages in the
kernel log.
Regards,
Hans
>
> Laurent Pinchart (1):
> v4l: omap4iss: Add support for OMAP4 camera interface - Build system
>
> Sergio Aguirre (5):
> v4l: omap4iss: Add support for OMAP4 camera interface - Core
> v4l: omap4iss: Add support for OMAP4 camera interface - Video devices
> v4l: omap4iss: Add support for OMAP4 camera interface - CSI receivers
> v4l: omap4iss: Add support for OMAP4 camera interface - IPIPE(IF)
> v4l: omap4iss: Add support for OMAP4 camera interface - Resizer
>
> Documentation/video4linux/omap4_camera.txt | 63 ++
> drivers/staging/media/Kconfig | 2 +
> drivers/staging/media/Makefile | 1 +
> drivers/staging/media/omap4iss/Kconfig | 12 +
> drivers/staging/media/omap4iss/Makefile | 6 +
> drivers/staging/media/omap4iss/TODO | 4 +
> drivers/staging/media/omap4iss/iss.c | 1477 ++++++++++++++++++++++++++
> drivers/staging/media/omap4iss/iss.h | 153 +++
> drivers/staging/media/omap4iss/iss_csi2.c | 1368 ++++++++++++++++++++++++
> drivers/staging/media/omap4iss/iss_csi2.h | 156 +++
> drivers/staging/media/omap4iss/iss_csiphy.c | 278 +++++
> drivers/staging/media/omap4iss/iss_csiphy.h | 51 +
> drivers/staging/media/omap4iss/iss_ipipe.c | 581 ++++++++++
> drivers/staging/media/omap4iss/iss_ipipe.h | 67 ++
> drivers/staging/media/omap4iss/iss_ipipeif.c | 847 +++++++++++++++
> drivers/staging/media/omap4iss/iss_ipipeif.h | 92 ++
> drivers/staging/media/omap4iss/iss_regs.h | 883 +++++++++++++++
> drivers/staging/media/omap4iss/iss_resizer.c | 905 ++++++++++++++++
> drivers/staging/media/omap4iss/iss_resizer.h | 75 ++
> drivers/staging/media/omap4iss/iss_video.c | 1129 ++++++++++++++++++++
> drivers/staging/media/omap4iss/iss_video.h | 201 ++++
> include/media/omap4iss.h | 65 ++
> 22 files changed, 8416 insertions(+)
> create mode 100644 Documentation/video4linux/omap4_camera.txt
> create mode 100644 drivers/staging/media/omap4iss/Kconfig
> create mode 100644 drivers/staging/media/omap4iss/Makefile
> create mode 100644 drivers/staging/media/omap4iss/TODO
> create mode 100644 drivers/staging/media/omap4iss/iss.c
> create mode 100644 drivers/staging/media/omap4iss/iss.h
> create mode 100644 drivers/staging/media/omap4iss/iss_csi2.c
> create mode 100644 drivers/staging/media/omap4iss/iss_csi2.h
> create mode 100644 drivers/staging/media/omap4iss/iss_csiphy.c
> create mode 100644 drivers/staging/media/omap4iss/iss_csiphy.h
> create mode 100644 drivers/staging/media/omap4iss/iss_ipipe.c
> create mode 100644 drivers/staging/media/omap4iss/iss_ipipe.h
> create mode 100644 drivers/staging/media/omap4iss/iss_ipipeif.c
> create mode 100644 drivers/staging/media/omap4iss/iss_ipipeif.h
> create mode 100644 drivers/staging/media/omap4iss/iss_regs.h
> create mode 100644 drivers/staging/media/omap4iss/iss_resizer.c
> create mode 100644 drivers/staging/media/omap4iss/iss_resizer.h
> create mode 100644 drivers/staging/media/omap4iss/iss_video.c
> create mode 100644 drivers/staging/media/omap4iss/iss_video.h
> create mode 100644 include/media/omap4iss.h
>
next prev parent reply other threads:[~2013-10-03 7:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 23:55 [PATCH 0/6] OMAP4 ISS driver Laurent Pinchart
2013-10-02 23:55 ` [PATCH 1/6] v4l: omap4iss: Add support for OMAP4 camera interface - Core Laurent Pinchart
2013-10-03 6:40 ` Hans Verkuil
2013-10-05 21:49 ` Sakari Ailus
2013-11-03 23:43 ` Laurent Pinchart
2013-10-17 12:48 ` Mauro Carvalho Chehab
2013-10-17 13:10 ` Laurent Pinchart
2013-10-02 23:55 ` [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices Laurent Pinchart
2013-10-03 6:54 ` Hans Verkuil
2013-11-03 23:28 ` Laurent Pinchart
2013-11-04 8:34 ` Hans Verkuil
2013-11-05 3:23 ` Laurent Pinchart
2013-10-04 8:16 ` Dan Carpenter
2013-11-03 23:52 ` Laurent Pinchart
2013-10-02 23:55 ` [PATCH 3/6] v4l: omap4iss: Add support for OMAP4 camera interface - CSI receivers Laurent Pinchart
2013-10-02 23:55 ` [PATCH 4/6] v4l: omap4iss: Add support for OMAP4 camera interface - IPIPE(IF) Laurent Pinchart
2013-10-02 23:55 ` [PATCH 5/6] v4l: omap4iss: Add support for OMAP4 camera interface - Resizer Laurent Pinchart
2013-10-02 23:55 ` [PATCH 6/6] v4l: omap4iss: Add support for OMAP4 camera interface - Build system Laurent Pinchart
2013-10-03 7:00 ` Hans Verkuil [this message]
2013-10-03 9:28 ` [PATCH 0/6] OMAP4 ISS driver Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524D15F7.5070102@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=devel@driverdev.osuosl.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sergio.a.aguirre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.