From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 2/7] KVM: mmu: remove uninteresting MMU "new_cr3" callbacks Date: Thu, 03 Oct 2013 13:56:30 +0200 Message-ID: <524D5B6E.9020605@redhat.com> References: <1380725776-14948-1-git-send-email-pbonzini@redhat.com> <1380725776-14948-3-git-send-email-pbonzini@redhat.com> <20131003102305.GC17294@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Gleb Natapov Return-path: In-Reply-To: <20131003102305.GC17294@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 03/10/2013 12:23, Gleb Natapov ha scritto: >> > The commit message mentioned that "mmu_free_roots() is somewhat of an overkill, >> > but fixing that is more complicated and will be done after this minimal fix". >> > One year has passed, and no one really felt the need to do a different fix. >> > Wrap the call with a kvm_mmu_new_cr3 function for clarity, but remove the >> > callback. >> > > Well the reason for it is because whoever knew about the problem found > other things to do meanwhile :) But do we really need something smarter > here anyway? The situation described in e676505 should be extremely rare > even on non unrestricted guest HW and it happens during slow emulation > anyway, so optimization will likely not be noticeable. Yeah, and it's not like code that runs without paging will move to cr3 in a hot loop. :) Paolo