From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@kernel.org>,
Florian Lobmaier <florian.lobmaier@ams.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] regulator: as3722: Fix equation to calculate max_uV in regulator_lin_range macro
Date: Thu, 3 Oct 2013 18:01:37 +0530 [thread overview]
Message-ID: <524D63A9.10608@nvidia.com> (raw)
In-Reply-To: <1380718076.7307.1.camel@phoenix>
On Wednesday 02 October 2013 06:17 PM, Axel Lin wrote:
> Fix off-by-one in the equation to calculate max_uV and also adjust the _min_uV
> setting accordingly.
>
> For LDOs:
> The voltage select bits set the LDO output voltage 0.825V...3.3V, 25mV steps
> ....00h : LDO off
> 01h-24h : V_LDO4 = 0.8V + ldo4_vsel * 25mV
> = 0.825V + (ldo4_vsel - 1h) * 25mV
> 25h-3Fh : do not use
> 40h-7Fh : V_LDO4 = 1.725V + (ldo4_vsel - 40h) * 25mV
>
> For SD2345:
> The voltage select bits set the DC/DC output voltage level and power the DC/DC
> converter down.
> ....00h : DC/DC powered down
> 01h-40h : V_SD2 = 0.6V + sd2_vsel * 12.5mV
> = 0.6125V + (sd2_vsel - 1h) * 12.5mV
> 41h-70h : V_SD2 = 1.4V + (sd2_vsel - 40h) * 25mV
> = 1.425V + (sd2_vsel - 41h) * 25mV
> 71h-7Fh : V_SD2 = 2.6V + (sd2_vsel - 70h) * 50mV
> = 2.65V + (sd2_vsel - 71h) * 50mV
>
> Note, the third entry in as3722_sd2345_ranges is wrong in current code.
> Fix it based on the datasheet.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
next prev parent reply other threads:[~2013-10-03 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 12:47 [PATCH v2 1/2] regulator: as3722: Fix equation to calculate max_uV in regulator_lin_range macro Axel Lin
2013-10-02 12:49 ` [PATCH v2 2/2] regulator: as3722: Fix off-by-one n_voltages setting for SDx Axel Lin
2013-10-03 12:31 ` Laxman Dewangan [this message]
2013-10-03 15:50 ` [PATCH v2 1/2] regulator: as3722: Fix equation to calculate max_uV in regulator_lin_range macro Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524D63A9.10608@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=florian.lobmaier@ams.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.