From: Brian Norris <computersforpeace@gmail.com>
To: dedekind1@gmail.com
Cc: Huang Shijie <b32955@freescale.com>,
dwmw2@infradead.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v4 05/12] mtd: nand: print out the cell information for nand chip
Date: Thu, 03 Oct 2013 08:53:28 -0700 [thread overview]
Message-ID: <524D92F8.70603@gmail.com> (raw)
In-Reply-To: <1380810883.27358.432.camel@sauron.fi.intel.com>
On 10/03/2013 07:34 AM, Artem Bityutskiy wrote:
> On Mon, 2013-09-30 at 15:49 -0700, Brian Norris wrote:
>> On Wed, Sep 25, 2013 at 02:58:14PM +0800, Huang Shijie wrote:
>>> Print out the cell information for nand chip.
>>>
>>> (Since the message is too long, this patch also splits the log
>>> with two separate pr_info())
>>>
>>> Signed-off-by: Huang Shijie <b32955@freescale.com>
>>> ---
>>> drivers/mtd/nand/nand_base.c | 11 +++++++----
>>> 1 files changed, 7 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
>>> index 94d9084..b94309b 100644
>>> --- a/drivers/mtd/nand/nand_base.c
>>> +++ b/drivers/mtd/nand/nand_base.c
>>> @@ -3460,11 +3460,14 @@ ident_done:
>>> if (mtd->writesize > 512 && chip->cmdfunc == nand_command)
>>> chip->cmdfunc = nand_command_lp;
>>>
>>> - pr_info("NAND device: Manufacturer ID: 0x%02x, Chip ID: 0x%02x (%s %s),"
>>> - " %dMiB, page size: %d, OOB size: %d\n",
>>> + pr_info("NAND device: Manufacturer ID: 0x%02x,"
>>> + "Chip ID: 0x%02x (%s %s) \n",
>>
>> You're adding excess whitespace before the '\n'. I'll squash this
>> myself.
>
> Nowadays' fashion is to never split strings, Huang.
checkpatch.pl actually warns about this now, so I already fixed it but
didn't remember to mention it. Also, in splitting this string, Huang
removed a space (fixed as well).
Brian
next prev parent reply other threads:[~2013-10-03 15:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 6:58 [PATCH v4 00/12] About the SLC/MLC Huang Shijie
2013-09-25 6:58 ` [PATCH v4 01/12] mtd: nand: add a helper to check the SLC/MLC nand chip Huang Shijie
2013-09-25 6:58 ` [PATCH v4 02/12] mtd: nand: rename the cellinfo to bits_per_cell Huang Shijie
2013-09-30 22:15 ` Brian Norris
2013-09-25 6:58 ` [PATCH v4 03/12] mtd: nand: add the "bits per cell" info for legacy ID NAND Huang Shijie
2013-09-25 6:58 ` [PATCH v4 04/12] mtd: nand: set the cell information for ONFI nand Huang Shijie
2013-09-25 6:58 ` [PATCH v4 05/12] mtd: nand: print out the cell information for nand chip Huang Shijie
2013-09-30 22:49 ` Brian Norris
2013-10-03 14:34 ` Artem Bityutskiy
2013-10-03 15:53 ` Brian Norris [this message]
2013-09-25 6:58 ` [PATCH v4 06/12] mtd: gpmi: rewrite the gpmi_ecc_write_oob() to support the jffs2 Huang Shijie
2013-09-30 22:47 ` Brian Norris
2013-09-25 6:58 ` [PATCH v4 07/12] mtd: nand: add more comment for MTD_NANDFLASH/MTD_MLCNANDFLASH Huang Shijie
2013-09-25 6:58 ` [PATCH v4 08/12] mtd: nand: add a helper to detect the nand type Huang Shijie
2013-09-25 6:58 ` [PATCH v4 09/12] mtd: mtd-abi: " Huang Shijie
2013-09-25 6:58 ` [PATCH v4 10/12] mtd: add MTD_MLCNANDFLASH case for mtd_type_show() Huang Shijie
2013-09-25 6:58 ` [PATCH v4 11/12] jffs2: do not support the MLC nand Huang Shijie
2013-09-25 6:58 ` [PATCH v4 12/12] mtd: nand: fix the wrong mtd->type for nand chip Huang Shijie
2013-09-30 23:15 ` [PATCH v4 00/12] About the SLC/MLC Brian Norris
2013-10-08 2:38 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524D92F8.70603@gmail.com \
--to=computersforpeace@gmail.com \
--cc=b32955@freescale.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.