From: David Ahern <dsahern@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@kernel.org>,
Ramkumar Ramachandra <artagnon@gmail.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH] perf tool: report user-friendly error from timechart
Date: Thu, 03 Oct 2013 11:22:26 -0600 [thread overview]
Message-ID: <524DA7D2.80302@gmail.com> (raw)
In-Reply-To: <20131003170802.GB2436@ghostprotocols.net>
On 10/3/13 11:08 AM, Arnaldo Carvalho de Melo wrote:
> And is_valid_tracepoint() is a too big hammer, it traverses the whole
> directory looking for a match instead of plain build the path and do an
> access, its one of those things I need to ditch at some point. So far I
> just try to do a perf_evlist__add_newtp and if it fails, look at errno.
And a number of tracepoints depend on CONFIG settings so it is more than
just looking at whether debugfs is mounted and accessible/readable.
e.g., look at the message I put into perf-lock
David
prev parent reply other threads:[~2013-10-03 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 9:05 [PATCH] perf tool: report user-friendly error from timechart Ramkumar Ramachandra
2013-10-03 12:38 ` Ingo Molnar
2013-10-03 12:43 ` Ramkumar Ramachandra
2013-10-03 13:09 ` Ingo Molnar
2013-10-03 13:35 ` David Ahern
2013-10-03 17:08 ` Arnaldo Carvalho de Melo
2013-10-03 17:22 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524DA7D2.80302@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=artagnon@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.