From: Thavatchai Makphaibulchoke <thavatchai.makpahibulchoke@hp.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: T Makphaibulchoke <tmac@hp.com>, Theodore Ts'o <tytso@mit.edu>,
"linux-ext4@vger.kernel.org List" <linux-ext4@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
aswin@hp.com
Subject: Re: [PATCH 0/2] fs/ext4: increase parallelism in updating ext4 orphan list
Date: Thu, 03 Oct 2013 17:20:17 -0600 [thread overview]
Message-ID: <524DFBB1.5010101@hp.com> (raw)
In-Reply-To: <117221D9-7634-4131-95C2-7527C20F1F62@dilger.ca>
On 10/03/2013 06:28 PM, Andreas Dilger wrote:
>
> It would also be possible to have a completely contention-free orphan
> inode list by only generating the on-disk orphan linked list in a
> pre-commit callback hook from an efficient in-memory list. That would
> allow the common "add to orphan list; do something; remove from list"
> operations within a single transaction to run with minimal contention,
> and only the few rare cases of operations that exceed the lifetime of
> a single transaction would need to modify the on-disk list.
>
> For example, a per-cpu list would be quite efficient, or a hash table.
> Then, a jbd2 callback run before the transaction commits could modify
> the requisite inodes and superblock. All of those inodes are already
> (by definition) part of the transaction, so it won't add new buffers
> of the transaction.
>
> I'm not necessarily against the current patch, just thinking aloud about
> how it might be improved further.
>
> Cheers, Andreas
>
Thanks again for the suggestion. I'll rework this patch first and look into this possibility next.
Thanks,
Mak.
next prev parent reply other threads:[~2013-10-03 23:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 15:38 [PATCH 0/2] fs/ext4: increase parallelism in updating ext4 orphan list T Makphaibulchoke
2013-10-04 0:28 ` Andreas Dilger
2013-10-03 23:20 ` Thavatchai Makphaibulchoke [this message]
2014-04-02 16:29 ` [PATCH v2] " T Makphaibulchoke
2014-04-02 17:41 ` Jan Kara
2014-04-02 19:48 ` Thavatchai Makphaibulchoke
2014-04-14 16:56 ` Thavatchai Makphaibulchoke
2014-04-14 17:40 ` Jan Kara
2014-04-15 16:27 ` Thavatchai Makphaibulchoke
2014-04-15 17:25 ` Jan Kara
2014-04-15 20:22 ` Thavatchai Makphaibulchoke
2014-04-24 17:31 ` [PATCH v3] " T Makphaibulchoke
2014-04-30 10:10 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524DFBB1.5010101@hp.com \
--to=thavatchai.makpahibulchoke@hp.com \
--cc=adilger@dilger.ca \
--cc=aswin@hp.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tmac@hp.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.