From: Alex Courbot <acourbot@nvidia.com>
To: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Frank Rowand <frank.rowand@sonymobile.com>,
NeilBrown Brown <neilb@suse.de>,
Belisko Marek <marek.belisko@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: Bug report - gpio: improve error path in gpiolib
Date: Fri, 4 Oct 2013 10:27:56 +0900 [thread overview]
Message-ID: <524E199C.8030108@nvidia.com> (raw)
In-Reply-To: <F7C544E1-F25D-4E83-9896-A761ADBEBA93@goldelico.com>
Hi Nikolaus,
On 10/03/2013 01:22 AM, Dr. H. Nikolaus Schaller wrote:
> Hi Alexandre,
> i think have traced down one problem we have to the latest patch in 3.12-rc:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpio/gpiolib.c?id=be1a4b13089b1e18da83a549d49163ccad3c19ba
>
> The problem is that by this patch a desc == NULL now returns -EINVAL while earlier it did return an -EPROBE_DEFER, which I consider the better option.
>
> By this -EINVAL, now some dependent drivers are no longer initialized.
>
> So I't suggest to revert that.
Adding Linus since he authored the patch.
I suppose the behavior should not change indeed. But could you specify
which use-case now returns -EINVAL instead of -EPROBE_DEFER? It is not
obvious by just looking at the patch alone.
Thanks,
Alex.
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
next parent reply other threads:[~2013-10-04 1:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F7C544E1-F25D-4E83-9896-A761ADBEBA93@goldelico.com>
2013-10-04 1:27 ` Alex Courbot [this message]
2013-10-04 6:21 ` Bug report - gpio: improve error path in gpiolib Dr. H. Nikolaus Schaller
2013-10-04 18:02 ` Alexandre Courbot
2013-10-05 20:50 ` Dr. H. Nikolaus Schaller
2013-10-06 18:55 ` Alexandre Courbot
2013-10-11 14:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524E199C.8030108@nvidia.com \
--to=acourbot@nvidia.com \
--cc=frank.rowand@sonymobile.com \
--cc=hns@goldelico.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.