From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [RFC] ASoC: core: Allow DAI links to be specified by using ACPI names
Date: Fri, 04 Oct 2013 09:28:27 +0300 [thread overview]
Message-ID: <524E600B.4070202@linux.intel.com> (raw)
In-Reply-To: <20131003161929.GA27287@sirena.org.uk>
On 10/03/2013 07:19 PM, Mark Brown wrote:
> On Thu, Oct 03, 2013 at 05:22:45PM +0300, Jarkko Nikula wrote:
>> On 10/03/2013 04:37 PM, Mark Brown wrote:
>>> This is making me wonder if we shouldn't be taking the stable names we
>>> get from ACPI as the dev_name() instead of our internal ones on ACPI
>>> systems (and possibly something similar on DT) rather than adding custom
>>> code like this.
>> This is actually somewhat confusing issue. I think it's relatively
>> easy to switch using ACPI names within ASoC core (by modifying
>> fmt_single_name or something like that).
>> Problem is that for ACPI enumerated client devices the dev_name(dev)
>> still comes from those subsystems as before. So for instance dev_
>> prints in codec driver or ASoC core keeps printing "rt5640 0-001c:"
>> as before and I personally find it a bit more confusing if internal
>> ASoC names don't match as easily with dev_ prints.
> You're misreading my suggestion. What I'm saying is that it seems like
> it might be useful to have dev_name() return the ACPI name - this would
> mean that everything, including all the dev_ prints, would use the same
> name which would then become stable and tied to hardware.
I see. Indeed, this sounds a better idea. At quick look is even more simple.
--
Jarkko
next prev parent reply other threads:[~2013-10-04 6:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 12:33 [RFC] ASoC: core: Allow DAI links to be specified by using ACPI names Jarkko Nikula
2013-10-03 13:37 ` Mark Brown
2013-10-03 14:22 ` Jarkko Nikula
2013-10-03 15:29 ` [alsa-devel] " Vinod Koul
2013-10-03 16:56 ` Liam Girdwood
2013-10-03 16:19 ` Mark Brown
2013-10-04 6:28 ` Jarkko Nikula [this message]
2013-10-04 6:55 ` Rafael J. Wysocki
2013-10-04 7:38 ` Jarkko Nikula
2013-10-04 17:17 ` Rafael J. Wysocki
2013-10-04 6:53 ` Rafael J. Wysocki
2013-10-04 7:22 ` Jarkko Nikula
2013-10-04 17:17 ` Rafael J. Wysocki
2013-10-24 9:51 ` Mark Brown
2013-10-25 6:53 ` Jarkko Nikula
2013-10-25 10:06 ` Mark Brown
2013-10-25 10:42 ` Jarkko Nikula
2013-10-28 11:53 ` [alsa-devel] " Liam Girdwood
2013-10-28 15:06 ` Mark Brown
2013-10-28 15:23 ` Jarkko Nikula
2013-10-28 16:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524E600B.4070202@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.