All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>,
	Jan Beulich <jbeulich@suse.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH RFC v13 02/20] pvh prep: code motion
Date: Fri, 4 Oct 2013 17:29:43 +0200	[thread overview]
Message-ID: <524EDEE7.9030708@citrix.com> (raw)
In-Reply-To: <1379955000-11050-3-git-send-email-george.dunlap@eu.citrix.com>

On 23/09/13 18:49, George Dunlap wrote:
> There are many functions where PVH requires some code in common with
> HVM.  Rearrange some of these functions so that the code is together.
> 
> In general, the HVM code that PVH also uses includes:
>  - cacheattr functionality
>  - paging
>  - hvm_funcs
>  - hvm_assert_evtchn_irq tasklet
>  - tm_list
>  - hvm_params
> 
> And code that PVH shares with PV but not with PVH:
>  - updating the domain wallclock
>  - setting v->is_initialized
> 
> There should be no end-to-end changes in behavior.

According to my bisection, this patch breaks HVM domains, here is the 
failure when trying to boot a HVM domain:

(XEN) <vm_launch_fail> error code 7
(XEN) domain_crash_sync called from vmcs.c:1224
(XEN) Domain 1 (vcpu#0) crashed on cpu#7:
(XEN) ----[ Xen-4.4-unstable  x86_64  debug=y  Not tainted ]----
(XEN) CPU:    7
(XEN) RIP:    0000:[<0000000000000000>]
(XEN) RFLAGS: 0000000000000002   CONTEXT: hvm guest
(XEN) rax: 0000000000000000   rbx: ffff83019a148000   rcx: ffff83019a14ff80
(XEN) rdx: ffff82d0801cd03f   rsi: 0000000000000000   rdi: ffff82d0801da5ec
(XEN) rbp: ffff82d080105a78   rsp: 0000000000000000   r8:  0000000000000004
(XEN) r9:  ffff82d080105ae7   r10: ffff83019a14ff70   r11: 0000000000000000
(XEN) r12: ffff83019a14ff50   r13: ffff83011da64000   r14: 0000000000000004
(XEN) r15: ffff82d080184a90   cr0: 0000000000000011   cr4: 0000000000000000
(XEN) cr3: 0000000000000000   cr2: 0000000000000000
(XEN) ds: 0000   es: 0000   fs: 0000   gs: 0000   ss: 0000   cs: 0000

  parent reply	other threads:[~2013-10-04 15:29 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23 16:49 [PATCH RFC v13 00/20] Introduce PVH domU support George Dunlap
2013-09-23 16:49 ` [PATCH RFC v13 01/20] Allow vmx_update_debug_state to be called when v!=current George Dunlap
2013-09-23 16:49 ` [PATCH RFC v13 02/20] pvh prep: code motion George Dunlap
2013-09-26  9:20   ` Tim Deegan
2013-10-04 15:29   ` Roger Pau Monné [this message]
2013-09-23 16:49 ` [PATCH RFC v13 03/20] Introduce pv guest type and has_hvm_container macros George Dunlap
2013-09-26 11:53   ` Tim Deegan
2013-09-26 12:54     ` Ian Campbell
2013-09-26 13:46     ` George Dunlap
2013-09-26 15:31       ` Konrad Rzeszutek Wilk
2013-09-26 16:24       ` Tim Deegan
2013-09-23 16:49 ` [PATCH RFC v13 04/20] pvh: Introduce PVH guest type George Dunlap
2013-09-23 16:49 ` [PATCH RFC v13 05/20] pvh: Disable unneeded features of HVM containers George Dunlap
2013-09-26 15:22   ` Jan Beulich
2013-11-04 12:31     ` George Dunlap
2013-09-23 16:49 ` [PATCH RFC v13 06/20] pvh: vmx-specific changes George Dunlap
2013-09-26 15:29   ` Jan Beulich
2013-11-07 14:14     ` George Dunlap
2013-11-07 14:29       ` Jan Beulich
2013-10-07 15:55   ` Roger Pau Monné
2013-10-07 16:06     ` George Dunlap
2013-10-07 16:12       ` Tim Deegan
2013-10-07 16:20         ` George Dunlap
2013-10-07 17:08           ` Tim Deegan
2013-10-08  8:45         ` Jan Beulich
2013-11-07 12:02           ` George Dunlap
2013-11-07 13:12             ` Jan Beulich
2013-09-23 16:49 ` [PATCH RFC v13 07/20] pvh: Do not allow PVH guests to change paging modes George Dunlap
2013-09-26 15:30   ` Jan Beulich
2013-09-23 16:49 ` [PATCH RFC v13 08/20] pvh: PVH access to hypercalls George Dunlap
2013-09-26 15:33   ` Jan Beulich
2013-09-27 21:15     ` Mukesh Rathor
2013-09-30  6:38       ` Jan Beulich
2013-09-23 16:49 ` [PATCH RFC v13 09/20] pvh: Use PV e820 George Dunlap
2013-09-27 17:57   ` Konrad Rzeszutek Wilk
2013-09-23 16:49 ` [PATCH RFC v13 10/20] pvh: Support guest_kernel_mode for PVH George Dunlap
2013-09-23 16:49 ` [PATCH RFC v13 11/20] pvh: Support read_segment_register " George Dunlap
2013-09-26 15:36   ` Jan Beulich
2013-09-23 16:49 ` [PATCH RFC v13 12/20] pvh: read_descriptor for PVH guests George Dunlap
2013-09-27 18:34   ` Konrad Rzeszutek Wilk
2013-09-23 16:49 ` [PATCH RFC v13 13/20] pvh: Set up more PV stuff in set_info_guest George Dunlap
2013-09-26 15:43   ` Jan Beulich
2013-11-07 15:57     ` George Dunlap
2013-09-23 16:49 ` [PATCH RFC v13 14/20] pvh: Use PV handlers for emulated forced invalid ops, cpuid, and IO George Dunlap
2013-09-26 15:52   ` Jan Beulich
2013-09-23 16:49 ` [PATCH RFC v13 15/20] pvh: Disable 32-bit guest support for now George Dunlap
2013-09-23 16:49 ` [PATCH RFC v13 16/20] pvh: Restrict tsc_mode to NEVER_EMULATE " George Dunlap
2013-09-23 16:49 ` [PATCH RFC v13 17/20] pvh: Disable debug traps when doing pv emulation for PVH domains George Dunlap
2013-09-26 15:55   ` Jan Beulich
2013-09-23 16:49 ` [PATCH RFC v13 18/20] pvh: Documentation George Dunlap
2013-09-23 16:49 ` [PATCH RFC v13 19/20] PVH xen tools: libxc changes to build a PVH guest George Dunlap
2013-09-27 18:37   ` Konrad Rzeszutek Wilk
2013-10-18 16:45   ` Roger Pau Monné
2013-11-04 11:56     ` George Dunlap
2013-11-04 13:18       ` Roger Pau Monné
2013-09-23 16:50 ` [PATCH RFC v13 20/20] PVH xen tools: libxl changes to create " George Dunlap
2013-09-27 18:38   ` Konrad Rzeszutek Wilk
2013-09-27 13:08 ` [PATCH RFC v13 00/20] Introduce PVH domU support Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524EDEE7.9030708@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.