From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSAhi-0000LX-E0 for qemu-devel@nongnu.org; Fri, 04 Oct 2013 15:06:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VSAhZ-0002Tg-DH for qemu-devel@nongnu.org; Fri, 04 Oct 2013 15:06:22 -0400 Sender: Paolo Bonzini Message-ID: <524F118E.5030000@redhat.com> Date: Fri, 04 Oct 2013 21:05:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1376344938-21374-1-git-send-email-pbonzini@redhat.com> <521B483D.9090203@redhat.com> <521B6775.5060102@suse.de> <521B6DCB.9030505@redhat.com> <521B7173.1030505@suse.de> <20130826161712.GA23449@redhat.com> <524EF113.6020201@redhat.com> <524EF24D.2030704@suse.de> In-Reply-To: <524EF24D.2030704@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: qemu-devel@nongnu.org, Doug Goldstein , "Michael S. Tsirkin" , qemu-stable@nongnu.org, Cole Robinson Il 04/10/2013 18:52, Andreas Färber ha scritto: > Am 04.10.2013 18:47, schrieb Paolo Bonzini: >> Il 26/08/2013 18:17, Michael S. Tsirkin ha scritto: >>> On Mon, Aug 26, 2013 at 05:17:07PM +0200, Andreas Färber wrote: >>>> Am 26.08.2013 17:01, schrieb Paolo Bonzini: >>>>> Il 26/08/2013 16:34, Andreas Färber ha scritto: >>>>>> Am 26.08.2013 14:21, schrieb Paolo Bonzini: >>>>>>> Il 13/08/2013 00:02, Paolo Bonzini ha scritto: >>>>>>>> vapic requires the VAPIC ROM to be mapped into RAM. This is not >>>>>>>> possible without PAM hardware. This fixes a segmentation fault >>>>>>>> running with -M isapc. >>>>>>>> >>>>>>>> Cc: qemu-stable@nongnu.org >>>>>>>> Signed-off-by: Paolo Bonzini >>>>>>>> --- >>>>>>>> >>>>>>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >>>>>>>> index a19e172..3aa244a 100644 >>>>>>>> --- a/hw/i386/pc_piix.c >>>>>>>> +++ b/hw/i386/pc_piix.c >>>>>>>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = { >>>>>>>> .init = pc_init_isa, >>>>>>>> .max_cpus = 1, >>>>>>>> .compat_props = (GlobalProperty[]) { >>>>>>>> + { >>>>>>>> + .driver = "apic-common", >>>>>>>> + .property = "kvmvapic", >>>>>>>> + .value = "off", >>>>>>>> + }, >>>>>>>> { /* end of list */ } >>>>>>>> }, >>>>>>>> DEFAULT_MACHINE_OPTIONS, >>>>>>>> >>>>>>> >>>>>>> Ping. >>>>>> >>>>>> I had double-checked that my pending qom-test covers isapc and succeeds >>>>>> with and without your patch, so apparently this is visible at runtime only. >>>>> >>>>> Yes, it only happens after kvmvapic is actually enabled by the option ROM. >>>> >>>> Maybe Michael can pick it up along with the compat refactorings? >>> >>> Sure, I'll put it on my tree but I already prepared a pull request >>> for today, it will go into the next one. >> >> Michael, can you post this patch together with the ACPI pull request? > > What about the comment wrt s/kvmvapic/vapic/g? Haven't seen any response > or v2. It needs a v2 indeed... weird... Paolo