From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Tejun Heo' <tj@kernel.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] ahci: use dev_info() instead of printk()
Date: Fri, 04 Oct 2013 22:18:25 +0200 [thread overview]
Message-ID: <524F2291.2060501@cogentembedded.com> (raw)
In-Reply-To: <000601cec0c1$58186d20$08494760$%han@samsung.com>
Hello.
On 04-10-2013 7:19, Jingoo Han wrote:
> Use the printk(KERN_INFO,...) call to to dev_info() instead,
> to tie into the dynamic debugging infrastructure.
I can't even parse this sentence, not to mention dev_info() has no
relation to dynamic debugging.
> Also change "raw" printk() call to dev_info() to provide a better
> error message to userspace so it can properly identify the device
> and not just have to guess.
I'm only seeing the second change in your patch.
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
[...]
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 9d715ae..8e28f92 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1343,7 +1343,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
> host->flags |= ATA_HOST_PARALLEL_SCAN;
> else
> - printk(KERN_INFO "ahci: SSS flag set, parallel bus scan disabled\n");
> + dev_info(&pdev->dev, "SSS flag set, parallel bus scan disabled\n");
WBR, Sergei
next prev parent reply other threads:[~2013-10-04 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 5:19 [PATCH 1/2] ahci: use dev_info() instead of printk() Jingoo Han
2013-10-04 5:20 ` [PATCH 2/2] ahci_platform: " Jingoo Han
2013-10-04 20:19 ` Sergei Shtylyov
2013-10-04 20:18 ` Sergei Shtylyov [this message]
2013-10-05 0:04 ` [PATCH 1/2] ahci: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524F2291.2060501@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=jg1.han@samsung.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.