From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 6/8] staging:iio:ad9852: Use spi_sync_transfer()
Date: Sat, 05 Oct 2013 12:01:37 +0100 [thread overview]
Message-ID: <524FF191.1000302@kernel.org> (raw)
In-Reply-To: <1380959108-21775-6-git-send-email-lars@metafoo.de>
On 10/05/13 08:45, Lars-Peter Clausen wrote:
> Use the spi_sync_transfer() helper function instead of open-coding it. Makes
> the code a bit shorter.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
applied.
> ---
> drivers/staging/iio/frequency/ad9852.c | 45 +++++++++-------------------------
> 1 file changed, 11 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/staging/iio/frequency/ad9852.c b/drivers/staging/iio/frequency/ad9852.c
> index 4be2cf8..11e4367 100644
> --- a/drivers/staging/iio/frequency/ad9852.c
> +++ b/drivers/staging/iio/frequency/ad9852.c
> @@ -67,7 +67,6 @@ static ssize_t ad9852_set_parameter(struct device *dev,
> const char *buf,
> size_t len)
> {
> - struct spi_message msg;
> struct spi_transfer xfer;
> int ret;
> struct ad9852_config *config = (struct ad9852_config *)buf;
> @@ -78,99 +77,77 @@ static ssize_t ad9852_set_parameter(struct device *dev,
> xfer.tx_buf = &config->phajst0[0];
> mutex_lock(&st->lock);
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 3;
> xfer.tx_buf = &config->phajst1[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 6;
> xfer.tx_buf = &config->fretun1[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 6;
> xfer.tx_buf = &config->fretun2[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 6;
> xfer.tx_buf = &config->dltafre[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 5;
> xfer.tx_buf = &config->updtclk[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 4;
> xfer.tx_buf = &config->ramprat[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 5;
> xfer.tx_buf = &config->control[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 3;
> xfer.tx_buf = &config->outpskm[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 2;
> xfer.tx_buf = &config->outpskr[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 3;
> xfer.tx_buf = &config->daccntl[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
> error_ret:
>
next prev parent reply other threads:[~2013-10-05 10:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 7:45 [PATCH 1/8] iio:ad5449: Use spi_sync_transfer() Lars-Peter Clausen
2013-10-05 7:45 ` [PATCH 2/8] iio:adis16080: " Lars-Peter Clausen
2013-10-05 10:59 ` Jonathan Cameron
2013-10-05 7:45 ` [PATCH 3/8] iio:adxrs450: " Lars-Peter Clausen
2013-10-05 10:59 ` Jonathan Cameron
2013-10-05 7:45 ` [PATCH 4/8] iio:adis16130: " Lars-Peter Clausen
2013-10-05 11:00 ` Jonathan Cameron
2013-10-05 11:00 ` Jonathan Cameron
2013-10-05 7:45 ` [PATCH 5/8] staging:iio:adis16220: " Lars-Peter Clausen
2013-10-05 11:01 ` Jonathan Cameron
2013-10-05 7:45 ` [PATCH 6/8] staging:iio:ad9852: " Lars-Peter Clausen
2013-10-05 11:01 ` Jonathan Cameron [this message]
2013-10-05 7:45 ` [PATCH 7/8] staging:iio:ad9910: " Lars-Peter Clausen
2013-10-05 11:01 ` Jonathan Cameron
2013-10-05 7:45 ` [PATCH 8/8] staging:iio:ad9951: " Lars-Peter Clausen
2013-10-05 11:02 ` Jonathan Cameron
2013-10-05 10:58 ` [PATCH 1/8] iio:ad5449: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524FF191.1000302@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.