From: Chen Gang <gang.chen@asianux.com>
To: Al Viro <viro@zeniv.linux.org.uk>, Thomas Gleixner <tglx@linutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 which express the maximize size of "%d" or "%u".
Date: Sat, 05 Oct 2013 23:19:48 +0800 [thread overview]
Message-ID: <52502E14.5040507@asianux.com> (raw)
Theoretically, the maximize size of "%d" or "%u" is 11 (10 + '\0'), so
need set MAX_NAMELEN 11 instead of 10.
In real world, it may not cause issue, but still recommend to fix this
'theoretical' bug (especially original definition already considered
about 'theoretical' using).
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
kernel/irq/proc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
index 36f6ee1..4e9a9ee 100644
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -305,7 +305,7 @@ void register_handler_proc(unsigned int irq, struct irqaction *action)
#undef MAX_NAMELEN
-#define MAX_NAMELEN 10
+#define MAX_NAMELEN 11
void register_irq_proc(unsigned int irq, struct irq_desc *desc)
{
--
1.7.7.
next reply other threads:[~2013-10-05 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 15:19 Chen Gang [this message]
2013-10-05 15:21 ` [PATCH] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 which express the maximize size of "%d" or "%u" Chen Gang
2013-10-05 15:41 ` Joe Perches
2013-10-05 15:46 ` Chen Gang
2013-10-05 16:08 ` Richard Weinberger
2013-10-05 16:50 ` Chen Gang
2013-10-05 17:06 ` Chen Gang
2013-10-05 17:45 ` Richard Weinberger
2013-10-06 0:37 ` Chen Gang
2013-10-06 15:57 ` Chen Gang
2013-10-07 10:47 ` [PATCH v2] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 and use "%u" instead of "%d" for printing 'irq' Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52502E14.5040507@asianux.com \
--to=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.