All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH V3] xfstests: restrict 259 device sizes to multiples of 512
Date: Sat, 05 Oct 2013 21:40:00 -0500	[thread overview]
Message-ID: <5250CD80.9090708@sandeen.net> (raw)
In-Reply-To: <5250CC9B.50807@sandeen.net>

Test 259 tries to make a loop device size which is 1 byte less
than 4T; losetup now warns that this makes little sense, and
the warning breaks the test output:

    +losetup: /mnt/test/259.image: warning: file does not fit into a 512-byte sector the end of the file will be ignored.

The RH QE testcase did originally use loopback, so did
not in effect test anything other than 512-multiple boundaries.

Just drop the non-512-byte-multiple cases, they produce
devices exactly the same size as their 512-byte-multiple
neighbors.

(FWIW, this is a regression test for the bug that
d943b11 mkfs: get size of device properly
fixed.)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

V2, sorry, sent wrong version that still had a 1025 "del"
value.

V3, .out file too, cripes.  No more saturday night patches,
sorry.

diff --git a/tests/xfs/259 b/tests/xfs/259
index 59eeaca..b8bd69a 100755
--- a/tests/xfs/259
+++ b/tests/xfs/259
@@ -48,7 +48,7 @@ testfile=$TEST_DIR/259.image
 
 # Test various sizes slightly less than 4 TB
 four_TB=$(_math "2^42")
-for del in 1 512 1024 1025 2048 4096; do
+for del in 512 1024 2048 4096; do
 	ddseek=$(_math "$four_TB - $del")
 	echo "Trying to make (4 TB - $del) B long xfs fs image"
 	rm -f "$testfile"
diff --git a/tests/xfs/259.out b/tests/xfs/259.out
index 263bb1b..6e0be9a 100644
--- a/tests/xfs/259.out
+++ b/tests/xfs/259.out
@@ -1,7 +1,5 @@
 QA output created by 259
-Trying to make (4 TB - 1) B long xfs fs image
 Trying to make (4 TB - 512) B long xfs fs image
 Trying to make (4 TB - 1024) B long xfs fs image
-Trying to make (4 TB - 1025) B long xfs fs image
 Trying to make (4 TB - 2048) B long xfs fs image
 Trying to make (4 TB - 4096) B long xfs fs image


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-10-06  2:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-06  2:25 [PATCH] xfstests: restrict 259 device sizes to multiples of 512 Eric Sandeen
2013-10-06  2:36 ` [PATCH V2] " Eric Sandeen
2013-10-06  2:40   ` Eric Sandeen [this message]
2013-10-08  0:46     ` [PATCH V3] " Dave Chinner
2013-10-16 20:26     ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5250CD80.9090708@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.