From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52910)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VShBc-00086R-EC
	for qemu-devel@nongnu.org; Sun, 06 Oct 2013 01:47:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VShBV-0002I9-0I
	for qemu-devel@nongnu.org; Sun, 06 Oct 2013 01:47:24 -0400
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:36423)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VShBU-0002H8-QD
	for qemu-devel@nongnu.org; Sun, 06 Oct 2013 01:47:16 -0400
Message-ID: <5250F956.6010009@weilnetz.de>
Date: Sun, 06 Oct 2013 07:47:02 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1380984092-18502-1-git-send-email-gabriel@kerneis.info>	<CAFEAcA_jYkiAxQPWOCfVi96Bb8U+i95ni12grxNBKgoP8jAJnw@mail.gmail.com>
	<20131005221820.GA3892@kerneis.info>
In-Reply-To: <20131005221820.GA3892@kerneis.info>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] config-host.mak: escape configure arguments
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gabriel Kerneis <gabriel@kerneis.info>, Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

Am 06.10.2013 00:18, schrieb Gabriel Kerneis:
> On Sun, Oct 06, 2013 at 12:54:08AM +0900, Peter Maydell wrote:
>> So this sed script appears to convert literal newlines in the input
>> Is that what's intended?
> Yes.
>
>> It doesn't seem very useful because if you cut-n-paste (or pipe)
>> 'hello\nworld' into a shell you get an actual backslash-n, not a newline.
> You're right.  Then the best is probably to expect that ./configure parameters
> will not get any litteral newline (and remove the sed call doing the
> substitution in my patch).  Or detect them (with grep) and print an error?
> Litteral newlines break badly config-host.mak anyway.
>


What about removing the comment with the configure parameters
from config-host.mak? Instead of that comment, we could write a
new file config.status as a script (executable) which can be called
to repeat the latest configuration.

This would have several benefits:

* Having the latest configuration in config.status is very common (GNU
autoconf).

* Easier code - no need to create a configure call from a comment.

* Users can call config.status if they want to repeat the configure process.

Regards,
Stefan