From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
dev@dpdk.org, "stable@dpdk.org" <stable@dpdk.org>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test: don't break terminal settings when running tests
Date: Sun, 17 Jan 2021 18:45:51 +0100 [thread overview]
Message-ID: <5251750.8YWXGV3c11@thomas> (raw)
In-Reply-To: <BYAPR11MB314316A1262C3070DAAC9C1BD7A80@BYAPR11MB3143.namprd11.prod.outlook.com>
14/01/2021 18:01, Van Haaren, Harry:
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Thursday, January 14, 2021 4:46 PM
> > To: Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry
> > <harry.van.haaren@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; Stephen Hemminger
> > <stephen@networkplumber.org>
> > Subject: [PATCH] test: don't break terminal settings when running tests
> >
> > When running one test (via DPDK_TEST) the test program
> > would leave the terminal in raw mode. This was because
> > it was setting up cmdline to do interactive input.
> >
> > The fix is to use cmdline_new() for the interactive
> > case.
> >
> > This also fixes a memory leak because the test
> > runner was never calling cmdline_free().
> >
> > Fixes: 9b848774a5dc ("test: use env variable to run tests")
> > Cc: harry.van.haaren@intel.com
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Tested-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks
prev parent reply other threads:[~2021-01-17 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 16:45 [dpdk-dev] [PATCH] test: don't break terminal settings when running tests Stephen Hemminger
2021-01-14 17:01 ` Van Haaren, Harry
2021-01-17 17:45 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5251750.8YWXGV3c11@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.