All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ngrep: fix static linking issue with libpcre
Date: Sun, 06 Oct 2013 21:59:22 +0200	[thread overview]
Message-ID: <5251C11A.10808@openwide.fr> (raw)


-lpcre must be placed in LIBS
So, use EXTRA_LIBS variable instead of LDFLAGS

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/ngrep/ngrep-1.45-configure-extra-lib.patch | 22 ++++++++++++++++++++++
 package/ngrep/ngrep.mk                             |  3 ++-
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100644 package/ngrep/ngrep-1.45-configure-extra-lib.patch

diff --git a/package/ngrep/ngrep-1.45-configure-extra-lib.patch b/package/ngrep/ngrep-1.45-configure-extra-lib.patch
new file mode 100644
index 0000000..aeb6a39
--- /dev/null
+++ b/package/ngrep/ngrep-1.45-configure-extra-lib.patch
@@ -0,0 +1,22 @@
+
+Signed-off-by: Romain Naour <romain.naour@openwide.fr>
+---
+ configure | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure b/configure
+index 621f1be..bd5649f 100755
+--- a/configure
++++ b/configure
+@@ -3533,7 +3533,7 @@ fi
+
+ EXTRA_DEFINES=""
+ EXTRA_INCLUDES=""
+-EXTRA_LIBS=""
++EXTRA_LIBS ?= ""
+
+
+
+--
+1.8.4
+
diff --git a/package/ngrep/ngrep.mk b/package/ngrep/ngrep.mk
index 99b8f46..1501dab 100644
--- a/package/ngrep/ngrep.mk
+++ b/package/ngrep/ngrep.mk
@@ -8,7 +8,8 @@ NGREP_VERSION = 1.45
 NGREP_SOURCE = ngrep-$(NGREP_VERSION).tar.bz2
 NGREP_SITE = http://downloads.sourceforge.net/project/ngrep/ngrep/$(NGREP_VERSION)
 NGREP_INSTALL_STAGING = YES
-NGREP_CONF_ENV = LDFLAGS="-lpcre"
+NGREP_CONF_ENV = EXTRA_LIBS="-lpcre"
+
 NGREP_CONF_OPT =  \
 	--with-pcap-includes=$(STAGING_DIR)/usr/include \
 	--enable-pcre \
-- 
1.8.4

             reply	other threads:[~2013-10-06 19:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-06 19:59 Romain Naour [this message]
2013-10-07 21:46 ` [Buildroot] [PATCH 1/1] ngrep: fix static linking issue with libpcre Arnout Vandecappelle
2013-10-08  8:12   ` Romain Naour
2013-10-08  8:20     ` Thomas Petazzoni
2013-10-08 17:41       ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5251C11A.10808@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.