From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCH v4 2/4] v4l: ti-vpe: Add helpers for creating VPDMA descriptors Date: Mon, 07 Oct 2013 09:46:36 +0200 Message-ID: <525266DC.5020409@xs4all.nl> References: <1376996457-17275-1-git-send-email-archit@ti.com> <1378462346-10880-1-git-send-email-archit@ti.com> <1378462346-10880-3-git-send-email-archit@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1378462346-10880-3-git-send-email-archit@ti.com> Sender: linux-media-owner@vger.kernel.org To: Archit Taneja Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com, linux-omap@vger.kernel.org, tomi.valkeinen@ti.com List-Id: linux-omap@vger.kernel.org On 09/06/2013 12:12 PM, Archit Taneja wrote: > Create functions which the VPE driver can use to create a VPDMA descriptor and > add it to a VPDMA descriptor list. These functions take a pointer to an existing > list, and append the configuration/data/control descriptor header to the list. > > In the case of configuration descriptors, the creation of a payload block may be > required(the payloads can hold VPE MMR values, or scaler coefficients). The > allocation of the payload buffer and it's content is left to the VPE driver. > However, the VPDMA library provides helper macros to create payload in the > correct format. > > Add debug functions to dump the descriptors in a way such that it's easy to see > the values of different fields in the descriptors. > > Signed-off-by: Archit Taneja Acked-by: Hans Verkuil Regards, Hans > --- > drivers/media/platform/ti-vpe/vpdma.c | 268 +++++++++++++++ > drivers/media/platform/ti-vpe/vpdma.h | 48 +++ > drivers/media/platform/ti-vpe/vpdma_priv.h | 522 +++++++++++++++++++++++++++++ > 3 files changed, 838 insertions(+) >