From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UGhpbGlwcGUgUsOpdG9ybmF6?= Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: fsl: imx-ssi: fix probe on imx31 Date: Mon, 07 Oct 2013 11:07:24 +0200 Message-ID: <525279CC.8080309@epfl.ch> References: <1380630971-11431-1-git-send-email-philippe.retornaz@epfl.ch> <1380630971-11431-2-git-send-email-philippe.retornaz@epfl.ch> <20131003155954.GV27287@sirena.org.uk> <524D963F.5080507@epfl.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Fabio Estevam Cc: Fabio Estevam , "alsa-devel@alsa-project.org" , Sascha Hauer , Mark Brown , Shawn Guo , "linux-arm-kernel@lists.infradead.org" List-Id: alsa-devel@alsa-project.org SGVsbG8KCkxlIDA0LzEwLzIwMTMgMjA6MTAsIEZhYmlvIEVzdGV2YW0gYSDDqWNyaXQgOgo+IE9u IFRodSwgT2N0IDMsIDIwMTMgYXQgMTowNyBQTSwgUGhpbGlwcGUgUsOpdG9ybmF6IHdyb3RlCj4+ IEl0IHdhcyB3b3JraW5nIGJ1dCBpdCBpcyBicm9rZW4gc2luY2UgYSBmZXcgcmVsZWFzZS4gVGhl cmUgaXMgbm8KPj4gbmVlZCB0byBydXNoIGZvciBhIGZpeCwgYm90aCBwYXRjaGVzIGNhbiBmb2xs b3cgdGhlIHN0YW5kYXJkCj4+IHByb2Nlc3MuCj4KPiBXZSBoYXZlIGJlZW4gdXNpbmcgIHNvdW5k L3NvYy9mc2wvZnNsX3NzaS5jIGZvciB0aGUgZHQgaW14IGFuZAo+IHBvd2VycGMgcGFydHMsIGFu ZCB0aGF0J3MgcHJvYmFibHkgdGhlIHJlYXNvbiB3ZSBoYXZlbid0IG5vdGljZWQgdGhpcwo+IGJ1 Zy4KCldlbGwsIEkgZG9uJ3QgdGhpbmsgaXQncyBmYWlyIHRvIGJyZWFrIGJvYXJkcyBqdXN0IGJl Y2F1c2UgdGhleSBhcmUgbm90Cih5ZXQpIGNvbnZlcnRlZCB0byBEVCAuLi4gdGhpcyBib2FyZCB3 YXMgbWVyZ2VkIGJlZm9yZSB0aGUgRFQgZXJhIG9uIEFSTS4KCkFueXdheSBldmVuIG9uIERUIGl0 J3MgYnJva2VuOiBiZWZvcmUgdGhlIHN3aXRjaCB0byB0aGUgY29tbW9uIGFzb2MgcGNtCmNvZGUs IHRoZSBkbWEgQVBJIHdhcyBtaXN1c2VkIHRvIGxldCBpdCB0aGluayB0aGF0IHRoZSBhdWRpbyBw YXJ0IG9mIHRoZQpTb0Mgd2FzIGRvaW5nIHRoZSBidXMgbWFzdGVyaW5nLCB3aGlsZSBpbiBmYWN0 IHRoZSBzZG1hIHdhcyBkb2luZyBpdC4KClJlZ2FyZHMsCgpQaGlsaXBwZQoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: philippe.retornaz@epfl.ch (=?UTF-8?B?UGhpbGlwcGUgUsOpdG9ybmF6?=) Date: Mon, 07 Oct 2013 11:07:24 +0200 Subject: [alsa-devel] [PATCH 1/2] ASoC: fsl: imx-ssi: fix probe on imx31 In-Reply-To: References: <1380630971-11431-1-git-send-email-philippe.retornaz@epfl.ch> <1380630971-11431-2-git-send-email-philippe.retornaz@epfl.ch> <20131003155954.GV27287@sirena.org.uk> <524D963F.5080507@epfl.ch> Message-ID: <525279CC.8080309@epfl.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Le 04/10/2013 20:10, Fabio Estevam a ?crit : > On Thu, Oct 3, 2013 at 1:07 PM, Philippe R?tornaz wrote >> It was working but it is broken since a few release. There is no >> need to rush for a fix, both patches can follow the standard >> process. > > We have been using sound/soc/fsl/fsl_ssi.c for the dt imx and > powerpc parts, and that's probably the reason we haven't noticed this > bug. Well, I don't think it's fair to break boards just because they are not (yet) converted to DT ... this board was merged before the DT era on ARM. Anyway even on DT it's broken: before the switch to the common asoc pcm code, the dma API was misused to let it think that the audio part of the SoC was doing the bus mastering, while in fact the sdma was doing it. Regards, Philippe