From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: <xen-devel@lists.xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
<netdev@vger.kernel.org>, Ian Campbell <ian.campbell@citrix.com>,
Paul Durrant <Paul.Durrant@citrix.com>
Subject: Re: [PATCHv1 net] xen-netback: transition to CLOSED when removing a VIF
Date: Mon, 7 Oct 2013 14:57:37 +0100 [thread overview]
Message-ID: <5252BDD1.1000301@citrix.com> (raw)
In-Reply-To: <20131007134314.GD28411@zion.uk.xensource.com>
On 07/10/13 14:43, Wei Liu wrote:
> On Mon, Oct 07, 2013 at 01:55:19PM +0100, David Vrabel wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> If a guest is destroyed without transitioning its frontend to CLOSED,
>> the domain becomes a zombie as netback was not grant unmapping the
>> shared rings.
>>
>> When removing a VIF, transition the backend to CLOSED so the VIF is
>> disconnected if necessary (which will unmap the shared rings etc).
>>
>> This fixes a regression introduced by
>> 279f438e36c0a70b23b86d2090aeec50155034a9 (xen-netback: Don't destroy
>> the netdev until the vif is shut down).
>>
>
> Is this regression solely caused by 279f438e36c or caused by both
> ea732dff5c and 279f438e36c? I ask because you make use of the new state
> machine introduced in ea732dff5c. Or are you simply using the new state
> machine to fix the regression instead of going back to old code?
I bisected it to 279f438. I'm just using the handy new state machine to
fix it.
David
next prev parent reply other threads:[~2013-10-07 13:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 12:55 [PATCHv1 net] xen-netback: transition to CLOSED when removing a VIF David Vrabel
2013-10-07 13:43 ` Wei Liu
2013-10-07 13:57 ` David Vrabel [this message]
2013-10-07 14:15 ` Wei Liu
2013-10-07 14:15 ` Wei Liu
2013-10-07 13:57 ` David Vrabel
2013-10-07 13:43 ` Wei Liu
2013-10-07 14:28 ` Paul Durrant
2013-10-07 14:28 ` Paul Durrant
2013-10-09 1:34 ` David Miller
2013-10-09 1:34 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-10-07 12:55 David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5252BDD1.1000301@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.