From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix number base handling of "load" command
Date: Mon, 07 Oct 2013 10:14:12 -0600 [thread overview]
Message-ID: <5252DDD4.8030300@wwwdotorg.org> (raw)
In-Reply-To: <1381000045-5938-1-git-send-email-wd@denx.de>
On 10/05/2013 01:07 PM, Wolfgang Denk wrote:
> A documented, almost all U-Boot commands expect numbers to be entered
s/A/As/ (btw, where?)
> in hexadecimal input format. (Exception: for historical reasons, the
> "sleep" command takes its argument in decimal input format.)
>
> This rule was broken for the "load" command; for details please see
> especially commits 045fa1e "fs: add filesystem switch libary,
> implement ls and fsload commands" and 3f83c87 "fs: fix number base
> behaviour change in fatload/ext*load". In the result, the load
> command would always require an explicit "0x" prefix for regular
> (i. e. base 16 formatted) input.
>
> Change this to use the standard notation of base 16 input format.
> While strictly speaking this is a change of the user interface, we
> hope that it will not cause trouble. Stephen Warren comments (see
> [1]):
>
> I suppose you can change the behaviour if you want; anyone
> writing "0x..." for their values presumably won't be
> affected, and if people really do assume all values in U-Boot
> are in hex, presumably nobody currently relies upon using
> non-prefixed values with the generic load command, since it
> doesn't work like that right now.
>
> [1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/171172
Acked-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2013-10-07 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 15:49 [U-Boot] [PATCH] cmd_nvedit.c: setenv_hex must prefix hex with '0x' Tom Rini
2013-10-04 21:35 ` Wolfgang Denk
2013-10-04 21:47 ` Stephen Warren
2013-10-04 22:12 ` Wolfgang Denk
2013-10-04 22:30 ` Stephen Warren
2013-10-05 19:07 ` [U-Boot] [PATCH] Fix number base handling of "load" command Wolfgang Denk
2013-10-07 16:14 ` Stephen Warren [this message]
2013-10-07 19:40 ` Wolfgang Denk
2013-10-07 19:42 ` [U-Boot] [PATCH V2] " Wolfgang Denk
2013-10-07 20:04 ` [U-Boot] [PATCH] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5252DDD4.8030300@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.