Re: [PATCH v2 00/33] HID: logitech-hidpp: G920 force-feedback fixes, rework, and cleanups

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Gideon,

On Thu, Nov 12, 2026 at 03:50:37PM +0100, Gideon Heinz wrote:
> Hi Dmitry,
>
> One more result, this time the combination you asked for: your input
> core patch in the kernel, plus the v2 series without patch 22/33 as
> the driver.
>
> Setup: CachyOS 7.3.4 kernel with only your "Input: destroy
> force-feedback device on input unregistration" patch built in. On top
> of that, hid-logitech-hidpp built out of tree against the 7.3.4
> headers from your v2 base (630059a5a632) with patches 1-21 and 23-33
> (7.3.4 already has a different G920 init fix, so I could not apply the
> series to the in-tree driver directly).
>
> Same reproduction: fftest holding the G920 event node at the effect
> prompt, rmmod hid_logitech_hidpp, then exiting fftest. Result: rmmod
> returns in 98 ms, there are no "Failed to send command to device!"
> lines at all, no hung task warning, and fftest exits normally with the
> machine staying up. For comparison, your input patch with the stock
> 7.3.4 driver took about 3 minutes and printed 12 failures, as in my
> previous mail.
>
> If you would like me to add a Tested-by for the combination (input
> patch + series without 22/33), please say so.

Thank you again for all the thorough testing and for verifying both the
input core patch and the updated hid-logitech-hidpp series!

I have added your Tested-by to the input core patch and will merge it
through the input tree myself. I will also give Benjamin and Jiri a
chance to take a look at the hid-logitech-hidpp series, and with your
permission I will add your Tested-by to those patches as well if I need
to respin them (and drop patch 22/33 in favor of the input core change).

Thanks.

-- 
Dmitry