From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-can@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 0/3] remove do_get_state() callback
Date: Mon, 07 Oct 2013 21:39:25 +0200 [thread overview]
Message-ID: <52530DED.5080604@pengutronix.de> (raw)
In-Reply-To: <52530AAB.4040808@grandegger.com>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
On 10/07/2013 09:25 PM, Wolfgang Grandegger wrote:
>> this patch series removes the do_get_state() callback from the driver
>> interface, as it is not needed to get the state of the interface.
Then I'll just take "[PATCH 1/3] can: ti_hecc: remove
priv->can.do_get_state() callback"
> I just realized that Max's GS-USB driver would require it because the
> device does not send asynchronous error and state change messages. But
> thinking more about it, I tend to nack such a solution as it breaks many
> user space programs.
The real need for a synchronous state callback to the driver has come
with the GS-USB device. I'll drop patches 2+3.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2013-10-07 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 14:46 [PATCH 0/3] remove do_get_state() callback Marc Kleine-Budde
2013-10-07 14:46 ` [PATCH 1/3] can: ti_hecc: remove priv->can.do_get_state() callback Marc Kleine-Budde
2013-10-07 14:46 ` [PATCH 2/3] can: dev: remove do_get_state() form can_fill_info() Marc Kleine-Budde
2013-10-07 14:46 ` [PATCH 3/3] can: dev: remove do_get_state() callback from struct can_priv Marc Kleine-Budde
2013-10-07 19:25 ` [PATCH 0/3] remove do_get_state() callback Wolfgang Grandegger
2013-10-07 19:39 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52530DED.5080604@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.