Re: [PATCH] kernel/panic.c: reduce 1 byte usage for print tainted buffer.

[Chen Gang <gang.chen@asianux.com>]

On 10/08/2013 12:35 AM, Alex Thorlton wrote:
> On Sat, Oct 05, 2013 at 11:50:39PM +0800, Chen Gang wrote:
>> sizeof("Tainted: ") already counts '\0', and after first sprintf(), 's'
>> will start from the current string end (its' value is '\0').
>>
>> So need not add additional 1 byte for maximized usage of 'buf' in
>> print_tainted().
>>
> 
> Looks fine to me; nothing too crazy going on here.  By the way, Robin
> isn't with us here at SGI any more.  He's at Cray, now, but I don't know
> his e-mail there :/
>  

OK, thanks.

>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> ---
>>  kernel/panic.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/kernel/panic.c b/kernel/panic.c
>> index b6c482c..c00b4ce 100644
>> --- a/kernel/panic.c
>> +++ b/kernel/panic.c
>> @@ -233,7 +233,7 @@ static const struct tnt tnts[] = {
>>   */
>>  const char *print_tainted(void)
>>  {
>> -	static char buf[ARRAY_SIZE(tnts) + sizeof("Tainted: ") + 1];
>> +	static char buf[ARRAY_SIZE(tnts) + sizeof("Tainted: ")];
>>  
>>  	if (tainted_mask) {
>>  		char *s;
>> -- 
>> 1.7.7.6
> 
> 


-- 
Chen Gang