From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 7/9] ARM: tegra: Enable DSI support on Dalmore
Date: Mon, 07 Oct 2013 15:25:52 -0600 [thread overview]
Message-ID: <525326E0.7080703@wwwdotorg.org> (raw)
In-Reply-To: <1381146528-18069-8-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 10/07/2013 05:48 AM, Thierry Reding wrote:
> Dalmore has a 10.1" WUXGA panel connected to one of the DSI outputs of
> the Tegra114.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> - lcd_bl_en_reg: regulator@2 {
> + usb1_vbus_reg: regulator@2 {
> compatible = "regulator-fixed";
> reg = <2>;
> - regulator-name = "lcd_bl_en";
> - regulator-min-microvolt = <5000000>;
> - regulator-max-microvolt = <5000000>;
> - enable-active-high;
> - gpio = <&gpio TEGRA_GPIO(H, 2) GPIO_ACTIVE_HIGH>;
> - };
> -
> - usb1_vbus_reg: regulator@3 {
> - compatible = "regulator-fixed";
> - reg = <3>;
> regulator-name = "usb1_vbus";
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
Rather than renumbering all the regulators, can you just delete the one
regulator and leave a gap in the numbering? That'd make the diff a lot
smaller and clearer. There's no need for the reg values to be contiguous
here, so I don't think the renumbering is useful in-and-of-itself.
next prev parent reply other threads:[~2013-10-07 21:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 11:48 [PATCH 0/9] ARM: tegra: Enable DSI and panel support Thierry Reding
[not found] ` <1381146528-18069-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-07 11:48 ` [PATCH 1/9] ARM: tegra: Enable LVDS and HDMI on Cardhu Thierry Reding
2013-10-07 11:48 ` [PATCH 2/9] ARM: tegra: Enable LVDS output on Harmony Thierry Reding
[not found] ` <1381146528-18069-3-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-07 21:14 ` Stephen Warren
[not found] ` <52532432.6040101-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-08 9:55 ` Thierry Reding
2013-10-07 11:48 ` [PATCH 3/9] ARM: tegra: Add MIPI calibration DT entries for Tegra114 Thierry Reding
[not found] ` <1381146528-18069-4-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-07 21:16 ` Stephen Warren
[not found] ` <5253249B.6010008-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-08 10:05 ` Thierry Reding
[not found] ` <20131008100529.GE19633-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-10-08 16:17 ` Stephen Warren
2013-10-07 11:48 ` [PATCH 4/9] ARM: tegra: Add host1x, DC and HDMI to Tegra114 device tree Thierry Reding
[not found] ` <1381146528-18069-5-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-07 21:19 ` Stephen Warren
[not found] ` <52532546.1010506-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-08 11:04 ` Thierry Reding
2013-10-07 11:48 ` [PATCH 5/9] ARM: tegra: Add Tegra114 DSI support Thierry Reding
[not found] ` <1381146528-18069-6-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-07 21:21 ` Stephen Warren
[not found] ` <525325C2.10107-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-08 11:07 ` Thierry Reding
2013-10-07 11:48 ` [PATCH 6/9] ARM: tegra: Add Tegra114 gr2d support Thierry Reding
2013-10-07 11:48 ` [PATCH 7/9] ARM: tegra: Enable DSI support on Dalmore Thierry Reding
[not found] ` <1381146528-18069-8-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-07 21:25 ` Stephen Warren [this message]
[not found] ` <525326E0.7080703-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-08 11:22 ` Thierry Reding
2013-10-07 11:48 ` [PATCH 8/9] ARM: tegra: Enable HDMI " Thierry Reding
2013-10-07 11:48 ` [PATCH 9/9] ARM: tegra: Enable DRM panel support Thierry Reding
2013-10-07 21:27 ` [PATCH 0/9] ARM: tegra: Enable DSI and " Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525326E0.7080703@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.