All of lore.kernel.org
 help / color / mirror / Atom feed
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 1/2] ARM: imx6qdl: provide pinctrl configurations for DAT3 pull-down
Date: Mon, 07 Oct 2013 20:52:40 -0600	[thread overview]
Message-ID: <52537378.1020904@wwwdotorg.org> (raw)
In-Reply-To: <20131008015426.GA7480@S2101-09.ap.freescale.net>

On 10/07/2013 07:54 PM, Shawn Guo wrote:
> On Mon, Oct 07, 2013 at 07:03:57PM +0100, Russell King - ARM Linux wrote:
>> On Mon, Oct 07, 2013 at 01:53:43PM +0800, Shawn Guo wrote:
>>> I think we can redefine only pad DAT3 in pinctrl_usdhc1_1_dat3cd, and
>>> overwrite the DAT3 configuration in pinctrl_usdhc1_1 to save the
>>> redundant data of other pads, something like the following.
>>>
>>> pinctrl_usdhc1_1_dat3cd: usdhc1grp-3 {
>>> 	fsl,pins = <
>>> 		MX6QDL_PAD_SD1_DAT3__SD1_DATA3 0x13059
>>> 	>;
>>> };
>>>
>>> &usdhc1 {
>>> 	pinctrl-names = "default";
>>> 	pinctrl-0 = <&pinctrl_usdhc1_1 &pinctrl_usdhc1_1_dat3cd>;
>>> 	...
>>> 	status = "okay";
>>> };
>>
>> Are you sure that this will always be the case?  This would assume that
>> the pinctrl entries are always processed sequentially.
> 
> That will always be the case per my understanding.  Otherwise, I would
> be so surprised.  Are you seeing any case that the entries are not
> processed sequentially?

Given the way the Linux code currently works, I think that will
currently happen in practice. However, there's nothing in the pinctrl DT
binding documentation that guarantees (or even mentions) such semantics.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Russell King - ARM Linux
	<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH RFC 1/2] ARM: imx6qdl: provide pinctrl configurations for DAT3 pull-down
Date: Mon, 07 Oct 2013 20:52:40 -0600	[thread overview]
Message-ID: <52537378.1020904@wwwdotorg.org> (raw)
In-Reply-To: <20131008015426.GA7480-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>

On 10/07/2013 07:54 PM, Shawn Guo wrote:
> On Mon, Oct 07, 2013 at 07:03:57PM +0100, Russell King - ARM Linux wrote:
>> On Mon, Oct 07, 2013 at 01:53:43PM +0800, Shawn Guo wrote:
>>> I think we can redefine only pad DAT3 in pinctrl_usdhc1_1_dat3cd, and
>>> overwrite the DAT3 configuration in pinctrl_usdhc1_1 to save the
>>> redundant data of other pads, something like the following.
>>>
>>> pinctrl_usdhc1_1_dat3cd: usdhc1grp-3 {
>>> 	fsl,pins = <
>>> 		MX6QDL_PAD_SD1_DAT3__SD1_DATA3 0x13059
>>> 	>;
>>> };
>>>
>>> &usdhc1 {
>>> 	pinctrl-names = "default";
>>> 	pinctrl-0 = <&pinctrl_usdhc1_1 &pinctrl_usdhc1_1_dat3cd>;
>>> 	...
>>> 	status = "okay";
>>> };
>>
>> Are you sure that this will always be the case?  This would assume that
>> the pinctrl entries are always processed sequentially.
> 
> That will always be the case per my understanding.  Otherwise, I would
> be so surprised.  Are you seeing any case that the entries are not
> processed sequentially?

Given the way the Linux code currently works, I think that will
currently happen in practice. However, there's nothing in the pinctrl DT
binding documentation that guarantees (or even mentions) such semantics.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-10-08  2:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-05 11:21 [PATCH RFC 0/2] Initial Solid Run Cubox-i carrier-1 support Russell King - ARM Linux
2013-10-05 11:21 ` Russell King - ARM Linux
2013-10-05 11:22 ` [PATCH RFC 1/2] ARM: imx6qdl: provide pinctrl configurations for DAT3 pull-down Russell King
2013-10-05 11:22   ` Russell King
2013-10-07  5:53   ` Shawn Guo
2013-10-07  5:53     ` Shawn Guo
2013-10-07 18:03     ` Russell King - ARM Linux
2013-10-07 18:03       ` Russell King - ARM Linux
2013-10-08  1:54       ` Shawn Guo
2013-10-08  1:54         ` Shawn Guo
2013-10-08  2:52         ` Stephen Warren [this message]
2013-10-08  2:52           ` Stephen Warren
2013-10-08  3:40           ` Shawn Guo
2013-10-08  3:40             ` Shawn Guo
2013-10-08  9:00             ` Russell King - ARM Linux
2013-10-08  9:00               ` Russell King - ARM Linux
2013-10-19 15:05               ` Russell King - ARM Linux
2013-10-19 15:05                 ` Russell King - ARM Linux
2013-10-21  0:46                 ` Shawn Guo
2013-10-21  0:46                   ` Shawn Guo
2013-10-25  2:16                   ` Shawn Guo
2013-10-25  2:16                     ` Shawn Guo
2013-10-05 11:23 ` [PATCH RFC 2/2] ARM: imx: initial IMX6 Cubox-i carrier-1 support Russell King
2013-10-05 11:23   ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52537378.1020904@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.