From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Michael Opdenacker <michael.opdenacker@free-electrons.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jslaby@suse.cz" <jslaby@suse.cz>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: tegra: remove deprecated IRQF_DISABLED
Date: Tue, 8 Oct 2013 12:31:15 +0530 [thread overview]
Message-ID: <5253ADBB.2040009@nvidia.com> (raw)
In-Reply-To: <5252EA3F.9090101@wwwdotorg.org>
On Monday 07 October 2013 10:37 PM, Stephen Warren wrote:
> On 10/06/2013 12:30 AM, Michael Opdenacker wrote:
>> This patch proposes to remove the use of the IRQF_DISABLED flag
>>
>> It's a NOOP since 2.6.35 and it will be removed one day.
> Laxman, care to comment? I'm not sure why the code explicitly specifies
> IRQF_DISABLED if it's already a no-op. Perhaps the code expects
> IRQF_DISABLED to do something, and hence there's some bug that needs to
> be fixed because of it doesn't?
>
We are having this flag in our downstream driver from very long and
hence this is there when I wrote for the upstream driver. I checked with
BT without this flag and it worked fine so it is fine to remove this flag.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
prev parent reply other threads:[~2013-10-08 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 6:30 [PATCH] serial: tegra: remove deprecated IRQF_DISABLED Michael Opdenacker
2013-10-06 6:30 ` Michael Opdenacker
[not found] ` <1381041017-12806-1-git-send-email-michael.opdenacker-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-10-07 17:07 ` Stephen Warren
2013-10-07 17:07 ` Stephen Warren
2013-10-08 7:01 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5253ADBB.2040009@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=michael.opdenacker@free-electrons.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.