From: Markos Chandras <Markos.Chandras@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] lighttpd: fix build failure without ipv6
Date: Tue, 8 Oct 2013 09:21:11 +0100 [thread overview]
Message-ID: <5253C077.4020503@imgtec.com> (raw)
In-Reply-To: <1381179735-21272-1-git-send-email-gustavo@zacarias.com.ar>
On 10/07/13 22:02, Gustavo Zacarias wrote:
> Reported in https://bugs.gentoo.org/show_bug.cgi?id=486426
> and http://redmine.lighttpd.net/issues/2515
> Autobuilders didn't hit it yet, but i did.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> ...ile.patch => lighttpd-01-Fix-default-config-file.patch} | 0
> package/lighttpd/lighttpd-02-mod_extforward.patch | 14 ++++++++++++++
> 2 files changed, 14 insertions(+)
> rename package/lighttpd/{lighttpd-Fix-default-config-file.patch => lighttpd-01-Fix-default-config-file.patch} (100%)
> create mode 100644 package/lighttpd/lighttpd-02-mod_extforward.patch
>
> diff --git a/package/lighttpd/lighttpd-Fix-default-config-file.patch b/package/lighttpd/lighttpd-01-Fix-default-config-file.patch
> similarity index 100%
> rename from package/lighttpd/lighttpd-Fix-default-config-file.patch
> rename to package/lighttpd/lighttpd-01-Fix-default-config-file.patch
> diff --git a/package/lighttpd/lighttpd-02-mod_extforward.patch b/package/lighttpd/lighttpd-02-mod_extforward.patch
> new file mode 100644
> index 0000000..3efd2b1
> --- /dev/null
> +++ b/package/lighttpd/lighttpd-02-mod_extforward.patch
> @@ -0,0 +1,14 @@
> +From http://redmine.lighttpd.net/issues/2515
> +
> +Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> +
> +--- a/src/mod_extforward.c (revision 2909)
> ++++ b/src/mod_extforward.c (working copy)
> +@@ -439,7 +439,6 @@
> + #ifdef HAVE_IPV6
> + ipstr_to_sockaddr(srv, real_remote_addr, &sock);
> + #else
> +- UNUSED(addrs_left);
> + sock.ipv4.sin_addr.s_addr = inet_addr(real_remote_addr);
> + sock.plain.sa_family = (sock.ipv4.sin_addr.s_addr == 0xFFFFFFFF) ? AF_UNSPEC : AF_INET;
> + #endif
>
oh this is rather embarrasing. I am taking care of the Gentoo bug myself
:/ I assumed the ipv6 is disabled by default since i didn't see it in
the lighttpd.mk makefile but reading the configure.ac it appears to
always be enabled :( Sorry about that.
Thanks for the patch!
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
next prev parent reply other threads:[~2013-10-08 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 21:02 [Buildroot] [PATCHv2] lighttpd: fix build failure without ipv6 Gustavo Zacarias
2013-10-08 8:21 ` Markos Chandras [this message]
2013-10-08 14:55 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5253C077.4020503@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.