From: Stefan Behrens <sbehrens@giantdisaster.de>
To: Zach Brown <zab@redhat.com>,
linux-btrfs@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH 02/12] btrfs-progs: check fopen failure in cmds-send
Date: Tue, 08 Oct 2013 10:41:54 +0200 [thread overview]
Message-ID: <5253C552.7080609@giantdisaster.de> (raw)
In-Reply-To: <1381182185-10896-3-git-send-email-zab@redhat.com>
On Mon, 7 Oct 2013 14:42:55 -0700, Zach Brown wrote:
> Check for fopen() failure. This shows up in static analysis as a
> possible null pointer derference.
>
> Signed-off-by: Zach Brown <zab@redhat.com>
> ---
> cmds-send.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/cmds-send.c b/cmds-send.c
> index 374d040..5f6ff86 100644
> --- a/cmds-send.c
> +++ b/cmds-send.c
> @@ -72,6 +72,11 @@ int find_mount_root(const char *path, char **mount_root)
> close(fd);
>
> mnttab = fopen("/proc/mounts", "r");
> + if (!mnttab) {
> + close(fd);
> + return -errno;
close() can modify errno.
And close(fd) is already called 4 lines above. You didn't run the static
code analysis again after applying your patch :)
> + }
> +
> while ((ent = getmntent(mnttab))) {
> len = strlen(ent->mnt_dir);
> if (strncmp(ent->mnt_dir, path, len) == 0) {
>
next prev parent reply other threads:[~2013-10-08 8:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 21:42 [RFC] another round of static analysis fixes Zach Brown
2013-10-07 21:42 ` [PATCH 01/12] btrfs-progs: check path alloc in corrupt block Zach Brown
2013-10-07 21:42 ` [PATCH 02/12] btrfs-progs: check fopen failure in cmds-send Zach Brown
2013-10-08 8:41 ` Stefan Behrens [this message]
2013-10-08 16:44 ` Zach Brown
2013-10-08 17:19 ` Zach Brown
2013-10-07 21:42 ` [PATCH 03/12] btrfs-progs: don't overrun name in find-collisions Zach Brown
2013-10-07 21:42 ` [PATCH 04/12] btrfs-progs: don't overflow read buffer in image Zach Brown
2013-10-07 21:42 ` [PATCH 05/12] btrfs-progs: check link_subvol name base Zach Brown
2013-10-07 21:42 ` [PATCH 06/12] btrfs-progs: remove dead block group checking Zach Brown
2013-10-07 21:43 ` [PATCH 07/12] btrfs-progs: free eb in fixup_chunk_tree_block() Zach Brown
2013-10-07 21:43 ` [PATCH 08/12] btrfs-progs: don't leak path in verify_space_cache Zach Brown
2013-10-08 5:18 ` chandan
2013-10-07 21:43 ` [PATCH 09/12] btrfs-progs: don't deref pipefd[-1] Zach Brown
2013-10-07 21:45 ` Eric Sandeen
2013-10-07 21:47 ` Zach Brown
2013-10-07 21:43 ` [PATCH 10/12] btrfs-progs: don't overflow colors[] in fragments Zach Brown
2013-10-07 21:43 ` [PATCH 11/12] btrfs-progs: remove unused variables Zach Brown
2013-10-07 21:43 ` [PATCH 12/12] btrfs-progs: free leaked roots in calc-size Zach Brown
2013-10-08 16:38 ` [RFC] another round of static analysis fixes David Sterba
2013-10-08 17:20 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5253C552.7080609@giantdisaster.de \
--to=sbehrens@giantdisaster.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.