All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Kevin Wolf <kwolf@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] savevm/loadvm
Date: Tue, 08 Oct 2013 11:04:53 +0200	[thread overview]
Message-ID: <5253CAB5.7040708@redhat.com> (raw)
In-Reply-To: <5253C514.6090103@ozlabs.ru>

Il 08/10/2013 10:40, Alexey Kardashevskiy ha scritto:
> However qcow2_save_vmstate() sets bs->growable to 1 for a short time
> (commit 178e08a58f40dd5aef2ce774fe0850f5d0e56918 from 2009) and this
> triggers a branch in bdrv_co_do_writev() which changes bs->total_sectors.
> So when QEMU writes snapshots to the file, the disk_size field of a
> snapshot has bigger value (for example 0x4.007b.8180).

I think you need to modify qcow2_save_vmstate to save and restore
bs->total_sectors.  Can you test that and if so post the patch?

Paolo

  reply	other threads:[~2013-10-08  9:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08  8:40 [Qemu-devel] savevm/loadvm Alexey Kardashevskiy
2013-10-08  9:04 ` Paolo Bonzini [this message]
2013-10-08  9:23   ` Kevin Wolf
2013-10-08  9:33     ` Paolo Bonzini
2013-10-09  7:15       ` Alexey Kardashevskiy
2013-10-09  7:47         ` Paolo Bonzini
2013-10-10  3:50           ` Alexey Kardashevskiy
2013-10-16  6:51             ` Alexey Kardashevskiy
2013-11-01 13:22               ` Alexey Kardashevskiy
2013-11-01 14:16 ` Max Reitz
2013-11-03  0:34   ` Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5253CAB5.7040708@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.