From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] savevm/loadvm
Date: Tue, 08 Oct 2013 11:33:40 +0200 [thread overview]
Message-ID: <5253D174.1060200@redhat.com> (raw)
In-Reply-To: <20131008092330.GB25109@dhcp-200-207.str.redhat.com>
Il 08/10/2013 11:23, Kevin Wolf ha scritto:
>> > I think you need to modify qcow2_save_vmstate to save and restore
>> > bs->total_sectors. Can you test that and if so post the patch?
> It's a regression introduced by commit df2a6f29, right?
Yes, that's what introduced the "if".
> What you suggest probably works as a quick hack to fix the bug. The VM
> state functions in qcow2 are getting uglier and uglier, though. Maybe
> they should avoid going through block.c and adding hacks to disable or
> revert side effects.
Yes, that would work too.
Paolo
next prev parent reply other threads:[~2013-10-08 9:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 8:40 [Qemu-devel] savevm/loadvm Alexey Kardashevskiy
2013-10-08 9:04 ` Paolo Bonzini
2013-10-08 9:23 ` Kevin Wolf
2013-10-08 9:33 ` Paolo Bonzini [this message]
2013-10-09 7:15 ` Alexey Kardashevskiy
2013-10-09 7:47 ` Paolo Bonzini
2013-10-10 3:50 ` Alexey Kardashevskiy
2013-10-16 6:51 ` Alexey Kardashevskiy
2013-11-01 13:22 ` Alexey Kardashevskiy
2013-11-01 14:16 ` Max Reitz
2013-11-03 0:34 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5253D174.1060200@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.