From mboxrd@z Thu Jan 1 00:00:00 1970 From: r.sricharan@ti.com (Sricharan R) Date: Tue, 8 Oct 2013 17:13:46 +0530 Subject: [PATCH v3 4/6] ARM: mm: Correct virt_to_phys patching for 64 bit physical addresses In-Reply-To: References: <1380835081-12129-1-git-send-email-santosh.shilimkar@ti.com> <1380835081-12129-5-git-send-email-santosh.shilimkar@ti.com> <524E541D.2030509@ti.com> <52530A98.1030708@ti.com> Message-ID: <5253EFF2.5030600@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 08 October 2013 01:12 AM, Nicolas Pitre wrote: > On Mon, 7 Oct 2013, Santosh Shilimkar wrote: > >> Update patch below with your review tag for records. >> >> Regards, >> Santosh > Micronit: > >> .data >> .globl __pv_phys_offset >> .type __pv_phys_offset, %object >> __pv_phys_offset: >> - .long 0 >> - .size __pv_phys_offset, . - __pv_phys_offset >> + .quad 0 >> + >> + .data >> + .globl __pv_offset >> + .type __pv_offset, %object >> __pv_offset: >> - .long 0 >> + .quad 0 > Please keep the .size statement for __pv_phys_offset, and adding one for > __pv_offset wouldn't hurt either. And the second .data is redundant. > Ok, will update this. Regards, Sricharan