From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 08 Oct 2013 14:31:17 +0200 (CEST) Received: from multi.imgtec.com ([194.200.65.239]:28690 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6827313Ab3JHMbPsDmJo (ORCPT ); Tue, 8 Oct 2013 14:31:15 +0200 Message-ID: <5253FB20.7050909@imgtec.com> Date: Tue, 8 Oct 2013 13:31:28 +0100 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Ralf Baechle CC: , Leonid Yegoshin Subject: Re: [PATCH] MIPS: Print correct PC in trace dump after NMI exception References: <1381232371-25017-1-git-send-email-markos.chandras@imgtec.com> <20131008121546.GI1615@linux-mips.org> In-Reply-To: <20131008121546.GI1615@linux-mips.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.31] X-SEF-Processed: 7_3_0_01192__2013_10_08_13_31_10 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 38268 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 10/08/13 13:15, Ralf Baechle wrote: > On Tue, Oct 08, 2013 at 12:39:31PM +0100, Markos Chandras wrote: > >> + /* >> + * Clear ERL - restore segment mapping >> + * Clear BEV - required for page fault exception handler to work >> + */ >> + mfc0 k0, CP0_STATUS >> + ori k0, k0, ST0_EXL >> + lui k1, %hi(~ST0_BEV) >> + ori k1, k1, %lo(~ST0_ERL) > > Why not: > > li k1 ~(ST0_BEV | ST0_ERL) I have no answer to that :) Looks good to me. > > If you were afraid gas might use $1 expanding this macro instruction - no, > it won't. A belt & suspenders approach might be to drop in a ".set noat"; > it would make the assembler throw an error if should ever see the need to > use $1. > yeah i don't think the assembler would pick $1 in this case but we could add ".set noat" just to be safe i suppose. Thanks for the review. Could you fix these problems for me or should i submit a new patch? From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from multi.imgtec.com ([194.200.65.239]:28690 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6827313Ab3JHMbPsDmJo (ORCPT ); Tue, 8 Oct 2013 14:31:15 +0200 Message-ID: <5253FB20.7050909@imgtec.com> Date: Tue, 8 Oct 2013 13:31:28 +0100 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH] MIPS: Print correct PC in trace dump after NMI exception References: <1381232371-25017-1-git-send-email-markos.chandras@imgtec.com> <20131008121546.GI1615@linux-mips.org> In-Reply-To: <20131008121546.GI1615@linux-mips.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Ralf Baechle Cc: linux-mips@linux-mips.org, Leonid Yegoshin Message-ID: <20131008123128.MZrPPb6yMzYyxt8b2D3WwvrxK3LTqs-9X_eL2ITXbck@z> On 10/08/13 13:15, Ralf Baechle wrote: > On Tue, Oct 08, 2013 at 12:39:31PM +0100, Markos Chandras wrote: > >> + /* >> + * Clear ERL - restore segment mapping >> + * Clear BEV - required for page fault exception handler to work >> + */ >> + mfc0 k0, CP0_STATUS >> + ori k0, k0, ST0_EXL >> + lui k1, %hi(~ST0_BEV) >> + ori k1, k1, %lo(~ST0_ERL) > > Why not: > > li k1 ~(ST0_BEV | ST0_ERL) I have no answer to that :) Looks good to me. > > If you were afraid gas might use $1 expanding this macro instruction - no, > it won't. A belt & suspenders approach might be to drop in a ".set noat"; > it would make the assembler throw an error if should ever see the need to > use $1. > yeah i don't think the assembler would pick $1 in this case but we could add ".set noat" just to be safe i suppose. Thanks for the review. Could you fix these problems for me or should i submit a new patch?