From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: patches@linaro.org, Keir Fraser <keir@xen.org>,
ian.campbell@citrix.com, Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/x86: Remove GB macro in asm-x86/config.h
Date: Tue, 8 Oct 2013 17:49:46 +0100 [thread overview]
Message-ID: <525437AA.1070703@citrix.com> (raw)
In-Reply-To: <1381250913-15913-1-git-send-email-julien.grall@linaro.org>
On 08/10/13 17:48, Julien Grall wrote:
> Commit 983843e "xen: Add macros MB and GB" introduce a generic GB macro.
> By mistake, the macro in asm-x86/config.h was not removed. This is result to
> a compilation error when Xen is build for x86.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> xen/include/asm-x86/config.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h
> index 3980e06..99d0e2c 100644
> --- a/xen/include/asm-x86/config.h
> +++ b/xen/include/asm-x86/config.h
> @@ -129,7 +129,6 @@ extern unsigned char boot_edid_info[128];
> #define PML4_ADDR(_slot) \
> (((_AC(_slot, UL) >> 8) * _AC(0xffff000000000000,UL)) | \
> (_AC(_slot, UL) << PML4_ENTRY_BITS))
> -#define GB(_gb) (_AC(_gb, UL) << 30)
>
> /*
> * Memory layout:
next prev parent reply other threads:[~2013-10-08 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 16:48 [PATCH] xen/x86: Remove GB macro in asm-x86/config.h Julien Grall
2013-10-08 16:49 ` Andrew Cooper [this message]
2013-10-08 17:11 ` Ian Campbell
2013-10-08 17:15 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525437AA.1070703@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@linaro.org \
--cc=keir@xen.org \
--cc=patches@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.