From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>,
lee.jones@linaro.org, sameo@linux.intel.com, broonie@kernel.org,
linus.walleij@linaro.org, akpm@linux-foundation.org
Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
rtc-linux@googlegroups.com, rob.herring@calxeda.com,
mark.rutland@arm.com, pawel.moll@arm.com, rob@landley.net,
ijc+devicetree@hellion.org.uk, grant.likely@linaro.org,
Florian Lobmaier <florian.lobmaier@ams.com>
Subject: Re: [PATCH V4 1/3] mfd: add support for ams AS3722 PMIC
Date: Tue, 08 Oct 2013 14:38:46 -0600 [thread overview]
Message-ID: <52546D56.2040607@wwwdotorg.org> (raw)
In-Reply-To: <1380729030-25896-2-git-send-email-ldewangan@nvidia.com>
On 10/02/2013 09:50 AM, Laxman Dewangan wrote:
> The ams AS3722 is a compact system PMU suitable for mobile phones,
> tablets etc. It has 4 DC/DC step-down regulators, 3 DC/DC step-down
> controller, 11 LDOs, RTC, automatic battery, temperature and
> over-current monitoring, 8 GPIOs, ADC and a watchdog.
> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
> + The first cell is the IRQ number.
Which IRQ number exist? Perhaps the IRQ IDs match some specific HW register?
> +Pinmux and GPIO:
> +- pinctrl-names: A pinctrl state named "default" must be defined, using the
> + bindings in pinctrl/pinctrl-binding.txt.
Why is the DT required to define a default state? If the board doesn't
need to set up any pinctrl settings, surely it shouldn't have to define
the default state.
> +- pinctrl[0...n]: Nodes for pin control to represents state 0 to state n.
These aren't nodes. Those are properties that contain phandles that
refer to nodes.
> + Each of these nodes contains different subnodes to represents
> + some desired configuration for a list of pins. This configuration can
> + include the mux function to select on those pin(s), and various pin
> + configuration parameters, such as pull-up, open drain.
What contains "these nodes"?
> +
> +Each subnode have following properties:
> +Required properties:
> + pins: List of pins. Valid options for pins properties are
> + gpio0, gpio1, gpio2, gpio3, gpio4, gpio5, gpio6, gpio7
> +
> +Optional properties:
> + Optional properties are
Why repeat that?
> + function, bias-disable, bias-pull-up, bias-pull-down,
> + bias-high-impedance, drive-open-drain.
> +
> + Valid options for funtion properties are:
s/funtion/function/
I would say "values" not "options", as I think I pointed out before, but
I supopse I don't care.
> +Optional sub nodes:
The following might make it clear where these optional nodes sit:
Optional sub nodes of "regulators":
-----------------------------------
> + Additional custom properties are listed below.
Required or optional?
next prev parent reply other threads:[~2013-10-08 20:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 15:50 [PATCH V4 0/3] Add AMS AS3722 mfd, pincontrol, regulator and RTC driver Laxman Dewangan
2013-10-02 15:50 ` Laxman Dewangan
2013-10-02 15:50 ` [PATCH V4 1/3] mfd: add support for ams AS3722 PMIC Laxman Dewangan
2013-10-02 15:50 ` Laxman Dewangan
[not found] ` <1380729030-25896-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-02 15:52 ` Lee Jones
2013-10-02 15:52 ` Lee Jones
2013-10-08 20:38 ` Stephen Warren [this message]
2013-10-02 15:50 ` [PATCH V5 2/3] pincntrl: add support for ams AS3722 pin control driver Laxman Dewangan
2013-10-02 15:50 ` Laxman Dewangan
2013-10-08 12:16 ` [rtc-linux] " Linus Walleij
2013-10-10 9:25 ` Laxman Dewangan
2013-10-10 15:39 ` Linus Walleij
2013-10-02 15:50 ` [PATCH V4 3/3] drivers/rtc/rtc-as3722: add RTC driver Laxman Dewangan
2013-10-02 15:50 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52546D56.2040607@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.lobmaier@ams.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.