From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Tue, 08 Oct 2013 15:34:33 -0600
Subject: [U-Boot] [PATCH 3/8] Tegra124: Add SPL/AVP (arm720t) cpu files
In-Reply-To: <20131008081320.GC1734@ulmo.nvidia.com>
References: <1381185778-25722-1-git-send-email-twarren@nvidia.com>	<1381185778-25722-3-git-send-email-twarren@nvidia.com>
	<20131008081320.GC1734@ulmo.nvidia.com>
Message-ID: <52547A69.4020602@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 10/08/2013 02:13 AM, Thierry Reding wrote:
> On Tue, Oct 08, 2013 at 12:42:53AM +0200, Tom Warren wrote:
>> This provides SPL support for T124 boards - AVP early init, plus
>> CPU (A15) init/jump to main U-Boot.

>> soc_type = tegra_get_chip(); -               if (soc_type ==
>> CHIPID_TEGRA30 || soc_type == CHIPID_TEGRA114) +               if
>> (soc_type == CHIPID_TEGRA30 || soc_type == CHIPID_TEGRA114 || +
>> soc_type == CHIPID_TEGRA124)
> 
> Perhaps:
> 
> if (soc_type >= CHIPID_TEGRA30)

Given that the only exception is Tegra20, wouldn't it be better as:

if (soc_type == CHIPID_TEGRA20)

and then swap the Tegra20/not-Tegra20 branches of the if statement?