Re: [PATCH v3] ARM: omap: edma: add suspend suspend/resume hooks

[Daniel Mack <zonque@gmail.com>]

Hi everyone,

On 09.10.2013 08:18, Gururaja Hebbar wrote:
> On Wednesday 09 October 2013 11:33 AM, Fernandes, Joel wrote:
>> Some temporary issues with my mua so forgive any artifacts in this
>> email.
>> 
>> On Oct 9, 2013, at 12:14 AM, "Hebbar, Gururaja"
>> <gururaja.hebbar@ti.com> wrote:
>> 
>>> On Wednesday 09 October 2013 09:58 AM, Joel Fernandes wrote:
>>>> On 10/01/2013 10:04 AM, Daniel Mack wrote:

>>> AFAIK, Suspend/resume should be quick. Allocating and
>>> deallocating on every iterating would be useless and time
>>> consuming.
>> 
>> Nobody said allocate and deallocate on every iteration. Allocate
>> once during the first suspend call and then don't have to allocate
>> on subsequent calls.
> 
> I couldn't find any code which allocates parameters inside suspend. 

Me neighter :)

But on a general note, I wonder whether it's really worth discussing and
merging this patch. As I wrote in the cover letter, it's just a quick
and dirty solution that I copied from a very old BSP tree, and I know
that the file I'm patching here is going to be removed soon anyway.
Actually, the sooner the better.

(And the 'v3' in the subject is really my bad, sorry - I only sent one
version of this patch ever).

I can respin the patch on top of the proper driver once all the edma
bits have eventually been moved to drivers/dma. Is anyone continuing
Matt Porter's work on this?


Thanks,
Daniel