All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org,
	Jan Vejvalka <jan.vejvalka@lfmotol.cuni.cz>,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev
Subject: Re: [PATCH 1/2] xen/swiotlb: relax alignment requirements
Date: Wed, 12 Feb 2025 07:53:13 +0100	[thread overview]
Message-ID: <5255102c-de9f-4cd8-8311-5d5b5eb26832@suse.com> (raw)
In-Reply-To: <20250211120432.29493-2-jgross@suse.com>

On 11.02.2025 13:04, Juergen Gross wrote:
> When mapping a buffer for DMA via .map_page or .map_sg DMA operations,
> there is no need to check the machine frames to be aligned according
> to the mapped areas size. All what is needed in these cases is that the
> buffer is contiguous at machine level.

Is this really true in all cases? Can't e.g. compound pages make it here,
with the caller then still being permitted to assume higher than page
alignment? Alignment checking in xen_swiotlb_map_page() would perhaps
need doing with the base address of the incoming page, i.e. excluding
the incoming offset.

Jan


  parent reply	other threads:[~2025-02-12  6:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 12:04 [PATCH 0/2] xen/swiotlb: one fix and one optimization Juergen Gross
2025-02-11 12:04 ` [PATCH 1/2] xen/swiotlb: relax alignment requirements Juergen Gross
2025-02-12  1:23   ` Stefano Stabellini
2025-02-12  6:53   ` Jan Beulich [this message]
2025-02-12 11:04     ` Jürgen Groß
2025-02-11 12:04 ` [PATCH 2/2] xen/swiotlb: don't destroy contiguous region in all cases Juergen Gross
2025-02-12  1:30   ` Stefano Stabellini
2025-02-12 11:15     ` Jürgen Groß
2025-02-12 21:14       ` Stefano Stabellini
2025-02-12  7:38   ` Jan Beulich
2025-02-12 11:11     ` Jürgen Groß
2025-02-12 11:49       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5255102c-de9f-4cd8-8311-5d5b5eb26832@suse.com \
    --to=jbeulich@suse.com \
    --cc=iommu@lists.linux.dev \
    --cc=jan.vejvalka@lfmotol.cuni.cz \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.