All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
To: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>,
	Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: baumber-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org,
	USB list <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Subject: Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600
Date: Wed, 09 Oct 2013 10:41:57 +0200	[thread overview]
Message-ID: <525516D5.6030200@ladisch.de> (raw)
In-Reply-To: <s5hwqlmc1y7.wl%tiwai-l3A5Bk7waGM@public.gmane.org>

Takashi Iwai wrote:
>> On Tue, 8 Oct 2013 baumber-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org wrote:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=62691
>>>
>>> Summary: no reset_resume for driver snd-usb-audio for logitech headset H600
>
> How about simply applying the same resume for reset_resume like below?
>
> ---
>
> diff --git a/sound/usb/card.c b/sound/usb/card.c
> index 9d9de8d..c591a83 100644
> --- a/sound/usb/card.c
> +++ b/sound/usb/card.c
> @@ -747,6 +747,7 @@ static struct usb_driver usb_audio_driver = {
>  	.disconnect =	usb_audio_disconnect,
>  	.suspend =	usb_audio_suspend,
>  	.resume =	usb_audio_resume,
> +	.reset_resume =	usb_audio_resume,
>  	.id_table =	usb_audio_ids,
>  	.supports_autosuspend = 1,
>  };

When the device was reset, the state of all mixer controls has been
lost.  Disconnecting the card (the default behaviour without
reset_resume) is the correct thing to do in this situation.

Userspace should pick up the USB device again when it reappears.
(But it doesn't.  Is this a PulseAudio or a KDE problem?)

And why does the kernel whine about the lack of a callback that is
documented as being optional?


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-10-09  8:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BLU0-SMTP368B73167BF4C991BFDCE6A11C0@phx.gbl>
     [not found] ` <BLU0-SMTP368B73167BF4C991BFDCE6A11C0-MsuGFMq8XAE@public.gmane.org>
2013-10-08 17:38   ` no reset_resume for driver snd-usb-audio for logitech headset H600 Alan Stern
     [not found]     ` <Pine.LNX.4.44L0.1310081335400.1102-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2013-10-09  7:56       ` [alsa-devel] " Takashi Iwai
     [not found]         ` <s5hwqlmc1y7.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2013-10-09  8:41           ` Clemens Ladisch [this message]
     [not found]             ` <525516D5.6030200-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2013-10-09  9:13               ` Takashi Iwai
     [not found]                 ` <s5hob6ybyd3.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2013-10-09  9:16                   ` Takashi Iwai
     [not found]                     ` <s5hmwmiby8c.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2013-10-20 21:18                       ` baumber-PkbjNfxxIARBDgjK7y7TUQ
     [not found]                         ` <BLU0-SMTP81EAAFDB9BB4E4600757CCA1000-MsuGFMq8XAE@public.gmane.org>
2013-10-20 21:35                           ` Takashi Iwai
     [not found]                             ` <s5hr4bfpqwe.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2013-11-10 15:43                               ` baumber-PkbjNfxxIARBDgjK7y7TUQ
2013-10-09 14:33               ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525516D5.6030200@ladisch.de \
    --to=clemens-p6gi/4k7komelga04laivw@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=baumber-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    --cc=tiwai-l3A5Bk7waGM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.