All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Tony Lindgren <tony@atomide.com>
Cc: Enric Balletbo i Serra <eballetbo@gmail.com>,
	bcousson@baylibre.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ARM: OMAP: igep0020: use display init from dss-common
Date: Wed, 9 Oct 2013 12:27:13 +0300	[thread overview]
Message-ID: <52552171.6050002@ti.com> (raw)
In-Reply-To: <1381310359-20668-3-git-send-email-javier.martinez@collabora.co.uk>

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On 09/10/13 12:19, Javier Martinez Canillas wrote:
> Now that display information and setup is made from dss-common
> there is no need to have this code in the board file.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
> 
> Changes since v2:
>  - None, this is a new patch added for v3.
> 
>  arch/arm/mach-omap2/board-igep0020.c | 41 +++---------------------------------
>  1 file changed, 3 insertions(+), 38 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
> index 06dbb2d..d648d50 100644
> --- a/arch/arm/mach-omap2/board-igep0020.c
> +++ b/arch/arm/mach-omap2/board-igep0020.c
> @@ -43,6 +43,7 @@
>  #include "board-flash.h"
>  #include "control.h"
>  #include "gpmc-onenand.h"
> +#include "dss-common.h"

I didn't try, but I think these can be now removed from the board file:

#include <video/omapdss.h>
#include <video/omap-panel-data.h>

For the series:

Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

  reply	other threads:[~2013-10-09  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09  9:19 [PATCH v3 0/2]: Add legacy display init for IGEPv2 board Javier Martinez Canillas
2013-10-09  9:19 ` [PATCH v3 1/2] ARM: OMAP2+: pdata-quirks: add " Javier Martinez Canillas
2013-10-09  9:19 ` [PATCH v3 2/2] ARM: OMAP: igep0020: use display init from dss-common Javier Martinez Canillas
2013-10-09  9:27   ` Tomi Valkeinen [this message]
2013-10-09 14:58     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52552171.6050002@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=eballetbo@gmail.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.