From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qcow2: Free preallocated zero clusters
Date: Wed, 09 Oct 2013 11:50:09 +0200 [thread overview]
Message-ID: <525526D1.4020100@redhat.com> (raw)
In-Reply-To: <20131009094438.GG8994@dhcp-200-207.str.redhat.com>
On 2013-10-09 11:44, Kevin Wolf wrote:
> Am 09.10.2013 um 10:44 hat Max Reitz geschrieben:
>> In qcow2_free_any_clusters, preallocated zero clusters should be freed
>> just as normal clusters are.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Thanks, applied to the block branch.
>
> Do you have a test case that would cause a leak previously?
>
> Kevin
Oh, right.
qemu-img create -f qcow2 f.qcow2 64M
qemu-io -c 'write 0 64M' -c 'write -z 0 64M' -c 'discard 0 64M' f.qcow2
qemu-img check f.qcow2
seems enough, I'll send that test case as a follow-up.
Max
prev parent reply other threads:[~2013-10-09 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 8:44 [Qemu-devel] [PATCH] qcow2: Free preallocated zero clusters Max Reitz
2013-10-09 9:44 ` Kevin Wolf
2013-10-09 9:50 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525526D1.4020100@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.