From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VTqnu-0006UC-Ey for kexec@lists.infradead.org; Wed, 09 Oct 2013 10:15:43 +0000 Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 6DABB3EE1D6 for ; Wed, 9 Oct 2013 19:15:13 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 4303545DE60 for ; Wed, 9 Oct 2013 19:15:13 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 204AA45DE6F for ; Wed, 9 Oct 2013 19:15:13 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 119781DB8051 for ; Wed, 9 Oct 2013 19:15:13 +0900 (JST) Received: from m1000.s.css.fujitsu.com (m1000.s.css.fujitsu.com [10.240.81.136]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id B60421DB804D for ; Wed, 9 Oct 2013 19:15:12 +0900 (JST) Message-ID: <52552C9F.2030404@jp.fujitsu.com> Date: Wed, 09 Oct 2013 19:14:55 +0900 From: HATAYAMA Daisuke MIME-Version: 1.0 Subject: Re: mmap for /proc/vmcore broken since 3.12-rc1 References: <20131002140356.63706540@holzheu> <524D0ADF.2010507@jp.fujitsu.com> <52521FA5.3040101@jp.fujitsu.com> In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Alexey Dobriyan Cc: kexec@lists.infradead.org, Linux Kernel , Jan Willeke , Michael Holzheu , "David S. Miller" , Vivek Goyal Hello, (2013/10/08 21:49), Alexey Dobriyan wrote: > On Mon, Oct 7, 2013 at 5:42 AM, HATAYAMA Daisuke > wrote: > >> +static unsigned long >> +get_unmapped_area_vmcore(struct file *filp, unsigned long addr, >> + unsigned long len, unsigned long pgoff, >> + unsigned long flags) >> +{ >> +#ifdef CONFIG_MMU >> + return current->mm->get_unmapped_area(filp, addr, len, pgoff, >> flags); >> +#else >> + return -EIO; >> +#endif >> +} >> + >> static const struct file_operations proc_vmcore_operations = { >> .read = read_vmcore, >> .llseek = default_llseek, >> .mmap = mmap_vmcore, >> + .get_unmapped_area = get_unmapped_area_vmcore, > > I think current->mm->get_unmapped_area should be used by core proc code. What do you actually suggest here? You mean moving this code in proc code? I don't think you suggest so. > ENOMEM bug looks unrelated though. > Next step I'll do is to look into vm_unmapped_region() that looks for for a region fit to a given mmap request and returns its address. In particular, I'll focus on when vm_unmapped_region() could return kernel-space address. -- Thanks. HATAYAMA, Daisuke _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757212Ab3JIKPQ (ORCPT ); Wed, 9 Oct 2013 06:15:16 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:59158 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752735Ab3JIKPO (ORCPT ); Wed, 9 Oct 2013 06:15:14 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.8.9 X-SHieldMailCheckerPolicyVersion: FJ-ISEC-20120718-2 Message-ID: <52552C9F.2030404@jp.fujitsu.com> Date: Wed, 09 Oct 2013 19:14:55 +0900 From: HATAYAMA Daisuke User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Alexey Dobriyan CC: Michael Holzheu , "David S. Miller" , Vivek Goyal , Jan Willeke , Linux Kernel , kexec@lists.infradead.org Subject: Re: mmap for /proc/vmcore broken since 3.12-rc1 References: <20131002140356.63706540@holzheu> <524D0ADF.2010507@jp.fujitsu.com> <52521FA5.3040101@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, (2013/10/08 21:49), Alexey Dobriyan wrote: > On Mon, Oct 7, 2013 at 5:42 AM, HATAYAMA Daisuke > wrote: > >> +static unsigned long >> +get_unmapped_area_vmcore(struct file *filp, unsigned long addr, >> + unsigned long len, unsigned long pgoff, >> + unsigned long flags) >> +{ >> +#ifdef CONFIG_MMU >> + return current->mm->get_unmapped_area(filp, addr, len, pgoff, >> flags); >> +#else >> + return -EIO; >> +#endif >> +} >> + >> static const struct file_operations proc_vmcore_operations = { >> .read = read_vmcore, >> .llseek = default_llseek, >> .mmap = mmap_vmcore, >> + .get_unmapped_area = get_unmapped_area_vmcore, > > I think current->mm->get_unmapped_area should be used by core proc code. What do you actually suggest here? You mean moving this code in proc code? I don't think you suggest so. > ENOMEM bug looks unrelated though. > Next step I'll do is to look into vm_unmapped_region() that looks for for a region fit to a given mmap request and returns its address. In particular, I'll focus on when vm_unmapped_region() could return kernel-space address. -- Thanks. HATAYAMA, Daisuke