From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTqpz-0001dS-WF for qemu-devel@nongnu.org; Wed, 09 Oct 2013 06:17:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTqpt-0004ga-VX for qemu-devel@nongnu.org; Wed, 09 Oct 2013 06:17:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTqpt-0004gO-Be for qemu-devel@nongnu.org; Wed, 09 Oct 2013 06:17:45 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r99AHi9o021681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 9 Oct 2013 06:17:44 -0400 Message-ID: <52552D45.6050909@redhat.com> Date: Wed, 09 Oct 2013 12:17:41 +0200 From: Max Reitz MIME-Version: 1.0 References: <1379666231-10443-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1379666231-10443-1-git-send-email-mreitz@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/6] Configure metadata overlap checks at runtime List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On 2013-09-20 10:37, Max Reitz wrote: > This series changes the way of selecting what metadata overlap checks t= o > perform from (currently) using a macro to using a variable contained in > BDRVQcowState which can be configured at runtime through several comman= d > line options. > > Although this does not seem necessary anymore regarding performance > (because I could not find any performance hits using cached overlap > checks), it seems cleaner to me this way. > > This series depends on: > - qcow2: Correct snapshots size for overlap check > > Max Reitz (6): > qcow2: Use negated overflow check mask > qcow2: Make overlap check mask variable > qcow2: Add overlap-check options > qcow2: Array assigning options to OL check bits > qcow2: Add more overlap check bitmask macros > qcow2: Evaluate overlap check options > > block/qcow2-cache.c | 8 ++--- > block/qcow2-cluster.c | 16 ++++----- > block/qcow2-refcount.c | 22 ++++++------ > block/qcow2-snapshot.c | 12 +++---- > block/qcow2.c | 93 +++++++++++++++++++++++++++++++++++++++++= ++++++--- > block/qcow2.h | 30 ++++++++++++---- > 6 files changed, 137 insertions(+), 44 deletions(-) Ping =E2=80=93 does anyone have comments on this series? It doesn't really seem to be required, since the current default setting=20 is fast enough (although I still have to do a performance test regarding=20 the host CPU usage). However, this series introduces a cleaner interface=20 to the overlap checks besides the option to change the overlap checks at=20 startup (which isn't just useful to users, but also a requirement for=20 I/O tests on overlap checks on inactive L1 tables). Max