From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VTqup-0003rE-0C for mharc-grub-devel@gnu.org; Wed, 09 Oct 2013 06:22:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTqui-0003jH-JQ for grub-devel@gnu.org; Wed, 09 Oct 2013 06:22:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTqud-00069T-8a for grub-devel@gnu.org; Wed, 09 Oct 2013 06:22:44 -0400 Received: from mail-ea0-x231.google.com ([2a00:1450:4013:c01::231]:33806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTquc-00069C-TK for grub-devel@gnu.org; Wed, 09 Oct 2013 06:22:39 -0400 Received: by mail-ea0-f177.google.com with SMTP id f15so284402eak.8 for ; Wed, 09 Oct 2013 03:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=G3sDyvas/NbnfjSTlm9HD8xdmnY1wV7pXfCP0KIulGE=; b=QChY0SrwfCfA/Wdw9Wf5UYB/bxmvfT5xf6dMjlJDG7N4zv9ozsTMegyj6WORrxyqXV zLIJQug7K1gMQ/G3d8ZvbXfLVf0tpDZ2gsAo0+qKEhqFPKvLjG6KKzK6DDAMP4T0FLYt UhPp8Zjx9QA726uT8dMu9jCxn1+5BSN9XFR68lsvwv528Y1LQA2kiX4iozwzLpw11sP3 eZip9ybf7rxabyLg+H0zP9SaYKNOPlBD/QOwpreCGU51XT0YKK0POHgPLBMEkUMk7/ih efIIiUrUIVQ4QovnTJz8eY88d3+DIM2XsfBXWVxT/yweNsViT357IaquznL6G4w9F767 50TA== X-Received: by 10.14.246.11 with SMTP id p11mr10567846eer.9.1381314157470; Wed, 09 Oct 2013 03:22:37 -0700 (PDT) Received: from [192.168.42.25] (215-226.197-178.cust.bluewin.ch. [178.197.226.215]) by mx.google.com with ESMTPSA id z12sm87035943eev.6.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 09 Oct 2013 03:22:36 -0700 (PDT) Message-ID: <52552E67.80700@gmail.com> Date: Wed, 09 Oct 2013 12:22:31 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130821 Icedove/17.0.8 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] A couple of fixes for OpenBSD References: <201310091139.26628.Ilya_Bakulin@genua.de> In-Reply-To: <201310091139.26628.Ilya_Bakulin@genua.de> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2BTFWFBDOOKAWFWUVVHUS" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::231 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Oct 2013 10:22:50 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BTFWFBDOOKAWFWUVVHUS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09.10.2013 11:39, Ilya Bakulin wrote: > Hi, > attached is a small fix for getroot.c to make the conversion between pa= rtition=20 > names and drive names work correctly on OpenBSD. This patch looks like one of the numerous fixes I've done recently. Do I get it correctly that you used some older version? Is there a problem with current trunk? > After applying this and previous patch, I am able to build GRUB2 both o= n=20 > 5.3/amd64 and 5.3/i386 and invoke grub-install, and the GRUB2 gets inst= alled=20 > in the MBR and then able to load the L4 kernel + tons of modules from F= AT32=20 > filesystem (using multiboot). >=20 > Thanks! >=20 > diff --git a/contrib/grub2/util/getroot.c b/contrib/grub2/util/getroot.= c > index 103a3d2..2dd8486 100644 > --- a/contrib/grub2/util/getroot.c > +++ b/contrib/grub2/util/getroot.c > @@ -913,7 +913,7 @@ grub_find_device (const char *dir, dev_t dev) > /* Found! */ > char *res; > char *cwd; > -#if defined(__NetBSD__) > +#if defined(__NetBSD__) || defined(__OpenBSD__) > /* Convert this block device to its character (raw) device. = */ > const char *template =3D "%s/r%s"; > #else > @@ -2360,7 +2360,7 @@ grub_util_biosdisk_get_grub_dev (const char *os_d= ev) > } > free (sys_disk); > =20 > -#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ||=20 > defined(__APPLE__) || defined(__NetBSD__) || defined (__s > +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ||=20 > defined(__APPLE__) || defined(__NetBSD__) || defined (__s > if (! S_ISCHR (st.st_mode)) > #else > if (! S_ISBLK (st.st_mode)) >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 ------enig2BTFWFBDOOKAWFWUVVHUS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlJVLmcACgkQNak7dOguQgnwUwD/YcB+uqpwTgVjAsd4POrWxq1o Upm3FvLhsnrN2vZtjzMBAKJ/ltdxqu4akzltviLwL+N2jL5ORuAdfqzCVEKGnWpK =CFsE -----END PGP SIGNATURE----- ------enig2BTFWFBDOOKAWFWUVVHUS--