From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 18/23] drm: shmobile: use vblank hooks in struct drm_crtc_funcs Date: Tue, 07 Feb 2017 16:05:38 +0200 Message-ID: <5255503.H0HOnfCQiI@avalon> References: <1486458995-31018-1-git-send-email-shawnguo@kernel.org> <1486458995-31018-19-git-send-email-shawnguo@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 215886E6BE for ; Tue, 7 Feb 2017 14:05:17 +0000 (UTC) In-Reply-To: <1486458995-31018-19-git-send-email-shawnguo@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Shawn Guo Cc: Neil Armstrong , Daniel Vetter , Liviu Dudau , Daniel Vetter , Marek Vasut , Alexey Brodkin , Russell King , Xinliang Liu , Tomi Valkeinen , Mali DP Maintainers , Ben Skeggs , Jyri Sarha , dri-devel@lists.freedesktop.org, Maxime Ripard List-Id: dri-devel@lists.freedesktop.org SGkgU2hhd24sCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFR1ZXNkYXkgMDcgRmViIDIw MTcgMTc6MTY6MzAgU2hhd24gR3VvIHdyb3RlOgo+IEZyb206IFNoYXduIEd1byA8c2hhd24uZ3Vv QGxpbmFyby5vcmc+Cj4gCj4gVGhlIHZibGFuayBob29rcyBpbiBzdHJ1Y3QgZHJtX2RyaXZlciBh cmUgZGVwcmVjYXRlZCBhbmQgb25seSBtZWFudCBmb3IKPiBsZWdhY3kgZHJpdmVycy4gIEZvciBt b2Rlcm4gZHJpdmVycyB3aXRoIERSSVZFUl9NT0RFU0VUIGZsYWcsIHRoZSBob29rcwo+IGluIHN0 cnVjdCBkcm1fY3J0Y19mdW5jcyBzaG91bGQgYmUgdXNlZCBpbnN0ZWFkLgo+IAo+IEFzIHRoZSBy ZXN1bHQsIHNobW9iX2RybV9jcnRjX2VuYWJsZV92YmxhbmsoKSBiZWNvbWVzIGEgc3RhdGljIGZ1 bmN0aW9uLAo+IGFsdGhvdWdoIGl0IGdldHMgbW92ZWQgYXJvdW5kIGEgYml0IHRvIHNhdmUgZm9y d2FyZCBkZWNsYXJhdGlvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTaGF3biBHdW8gPHNoYXduLmd1 b0BsaW5hcm8ub3JnPgo+IENjOiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlk ZWFzb25ib2FyZC5jb20+CgpSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5w aW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3NobW9i aWxlL3NobW9iX2RybV9jcnRjLmMgfCA1MSArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fY3J0Yy5oIHwgIDEgLQo+ICBkcml2 ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX2Rydi5jICB8IDE5IC0tLS0tLS0tLS0tLQo+ ICAzIGZpbGVzIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDM2IGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX2NydGMuYwo+ IGIvZHJpdmVycy9ncHUvZHJtL3NobW9iaWxlL3NobW9iX2RybV9jcnRjLmMgaW5kZXgKPiA0NDU0 NzY1NTE2OTUuLjgyNDQ4OTBlNmQ1MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc2ht b2JpbGUvc2htb2JfZHJtX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9zaG1vYmlsZS9z aG1vYl9kcm1fY3J0Yy5jCj4gQEAgLTQ3NiwxMCArNDc2LDQ1IEBAIHN0YXRpYyBpbnQgc2htb2Jf ZHJtX2NydGNfcGFnZV9mbGlwKHN0cnVjdCBkcm1fY3J0Ywo+ICpjcnRjLCByZXR1cm4gMDsKPiAg fQo+IAo+ICtzdGF0aWMgdm9pZCBzaG1vYl9kcm1fY3J0Y19lbmFibGVfdmJsYW5rKHN0cnVjdCBz aG1vYl9kcm1fZGV2aWNlICpzZGV2LAo+ICsJCQkJCSBib29sIGVuYWJsZSkKPiArewo+ICsJdW5z aWduZWQgbG9uZyBmbGFnczsKPiArCXUzMiBsZGludHI7Cj4gKwo+ICsJLyogQmUgY2FyZWZ1bCBu b3QgdG8gYWNrbm93bGVkZ2UgYW55IHBlbmRpbmcgaW50ZXJydXB0LiAqLwo+ICsJc3Bpbl9sb2Nr X2lycXNhdmUoJnNkZXYtPmlycV9sb2NrLCBmbGFncyk7Cj4gKwlsZGludHIgPSBsY2RjX3JlYWQo c2RldiwgTERJTlRSKSB8IExESU5UUl9TVEFUVVNfTUFTSzsKPiArCWlmIChlbmFibGUpCj4gKwkJ bGRpbnRyIHw9IExESU5UUl9WRUU7Cj4gKwllbHNlCj4gKwkJbGRpbnRyICY9IH5MRElOVFJfVkVF Owo+ICsJbGNkY193cml0ZShzZGV2LCBMRElOVFIsIGxkaW50cik7Cj4gKwlzcGluX3VubG9ja19p cnFyZXN0b3JlKCZzZGV2LT5pcnFfbG9jaywgZmxhZ3MpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50 IHNobW9iX2RybV9lbmFibGVfdmJsYW5rKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiArewo+ICsJ c3RydWN0IHNobW9iX2RybV9kZXZpY2UgKnNkZXYgPSBjcnRjLT5kZXYtPmRldl9wcml2YXRlOwo+ ICsKPiArCXNobW9iX2RybV9jcnRjX2VuYWJsZV92Ymxhbmsoc2RldiwgdHJ1ZSk7Cj4gKwo+ICsJ cmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIHNobW9iX2RybV9kaXNhYmxlX3ZibGFu ayhzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gK3sKPiArCXN0cnVjdCBzaG1vYl9kcm1fZGV2aWNl ICpzZGV2ID0gY3J0Yy0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiArCj4gKwlzaG1vYl9kcm1fY3J0Y19l bmFibGVfdmJsYW5rKHNkZXYsIGZhbHNlKTsKPiArfQo+ICsKPiAgc3RhdGljIGNvbnN0IHN0cnVj dCBkcm1fY3J0Y19mdW5jcyBjcnRjX2Z1bmNzID0gewo+ICAJLmRlc3Ryb3kgPSBkcm1fY3J0Y19j bGVhbnVwLAo+ICAJLnNldF9jb25maWcgPSBkcm1fY3J0Y19oZWxwZXJfc2V0X2NvbmZpZywKPiAg CS5wYWdlX2ZsaXAgPSBzaG1vYl9kcm1fY3J0Y19wYWdlX2ZsaXAsCj4gKwkuZW5hYmxlX3ZibGFu ayA9IHNobW9iX2RybV9lbmFibGVfdmJsYW5rLAo+ICsJLmRpc2FibGVfdmJsYW5rID0gc2htb2Jf ZHJtX2Rpc2FibGVfdmJsYW5rLAo+ICB9Owo+IAo+ICBpbnQgc2htb2JfZHJtX2NydGNfY3JlYXRl KHN0cnVjdCBzaG1vYl9kcm1fZGV2aWNlICpzZGV2KQo+IEBAIC01OTQsMjIgKzYyOSw2IEBAIGlu dCBzaG1vYl9kcm1fZW5jb2Rlcl9jcmVhdGUoc3RydWN0IHNobW9iX2RybV9kZXZpY2UKPiAqc2Rl dikgcmV0dXJuIDA7Cj4gIH0KPiAKPiAtdm9pZCBzaG1vYl9kcm1fY3J0Y19lbmFibGVfdmJsYW5r KHN0cnVjdCBzaG1vYl9kcm1fZGV2aWNlICpzZGV2LCBib29sCj4gZW5hYmxlKQo+IC17Cj4gLQl1 bnNpZ25lZCBsb25nIGZsYWdzOwo+IC0JdTMyIGxkaW50cjsKPiAtCj4gLQkvKiBCZSBjYXJlZnVs IG5vdCB0byBhY2tub3dsZWRnZSBhbnkgcGVuZGluZyBpbnRlcnJ1cHQuICovCj4gLQlzcGluX2xv Y2tfaXJxc2F2ZSgmc2Rldi0+aXJxX2xvY2ssIGZsYWdzKTsKPiAtCWxkaW50ciA9IGxjZGNfcmVh ZChzZGV2LCBMRElOVFIpIHwgTERJTlRSX1NUQVRVU19NQVNLOwo+IC0JaWYgKGVuYWJsZSkKPiAt CQlsZGludHIgfD0gTERJTlRSX1ZFRTsKPiAtCWVsc2UKPiAtCQlsZGludHIgJj0gfkxESU5UUl9W RUU7Cj4gLQlsY2RjX3dyaXRlKHNkZXYsIExESU5UUiwgbGRpbnRyKTsKPiAtCXNwaW5fdW5sb2Nr X2lycXJlc3RvcmUoJnNkZXYtPmlycV9sb2NrLCBmbGFncyk7Cj4gLX0KPiAtCj4gIC8qIC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQo+ICAgKiBDb25uZWN0b3IKPiAgICovCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fY3J0Yy5oCj4gYi9kcml2ZXJzL2dwdS9kcm0vc2ht b2JpbGUvc2htb2JfZHJtX2NydGMuaCBpbmRleAo+IDgxOGIzMTU0OWRkYy4uZjE1Mjk3M2RmMTFj IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fY3J0Yy5o Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3NobW9iaWxlL3NobW9iX2RybV9jcnRjLmgKPiBAQCAt NDcsNyArNDcsNiBAQCBzdHJ1Y3Qgc2htb2JfZHJtX2Nvbm5lY3RvciB7Cj4gIH07Cj4gCj4gIGlu dCBzaG1vYl9kcm1fY3J0Y19jcmVhdGUoc3RydWN0IHNobW9iX2RybV9kZXZpY2UgKnNkZXYpOwo+ IC12b2lkIHNobW9iX2RybV9jcnRjX2VuYWJsZV92Ymxhbmsoc3RydWN0IHNobW9iX2RybV9kZXZp Y2UgKnNkZXYsIGJvb2wKPiBlbmFibGUpOwo+ICB2b2lkIHNobW9iX2RybV9jcnRjX2ZpbmlzaF9w YWdlX2ZsaXAoc3RydWN0IHNobW9iX2RybV9jcnRjICpzY3J0Yyk7Cj4gIHZvaWQgc2htb2JfZHJt X2NydGNfc3VzcGVuZChzdHJ1Y3Qgc2htb2JfZHJtX2NydGMgKnNjcnRjKTsKPiAgdm9pZCBzaG1v Yl9kcm1fY3J0Y19yZXN1bWUoc3RydWN0IHNobW9iX2RybV9jcnRjICpzY3J0Yyk7Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fZHJ2LmMKPiBiL2RyaXZl cnMvZ3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fZHJ2LmMgaW5kZXggZDZiMDU0NWQyNTJkLi4z NGZlZmEwYmEwZjAKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2ht b2JfZHJtX2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3NobW9iaWxlL3NobW9iX2RybV9k cnYuYwo+IEBAIC0yMyw3ICsyMyw2IEBACj4gICNpbmNsdWRlIDxkcm0vZHJtX2NydGNfaGVscGVy Lmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2dlbV9jbWFfaGVscGVyLmg+Cj4gCj4gLSNpbmNsdWRl ICJzaG1vYl9kcm1fY3J0Yy5oIgo+ICAjaW5jbHVkZSAic2htb2JfZHJtX2Rydi5oIgo+ICAjaW5j bHVkZSAic2htb2JfZHJtX2ttcy5oIgo+ICAjaW5jbHVkZSAic2htb2JfZHJtX3BsYW5lLmgiCj4g QEAgLTIyMiwyMiArMjIxLDYgQEAgc3RhdGljIGlycXJldHVybl90IHNobW9iX2RybV9pcnEoaW50 IGlycSwgdm9pZCAqYXJnKQo+ICAJcmV0dXJuIElSUV9IQU5ETEVEOwo+ICB9Cj4gCj4gLXN0YXRp YyBpbnQgc2htb2JfZHJtX2VuYWJsZV92Ymxhbmsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5z aWduZWQgaW50Cj4gcGlwZSkgLXsKPiAtCXN0cnVjdCBzaG1vYl9kcm1fZGV2aWNlICpzZGV2ID0g ZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCj4gLQlzaG1vYl9kcm1fY3J0Y19lbmFibGVfdmJsYW5rKHNk ZXYsIHRydWUpOwo+IC0KPiAtCXJldHVybiAwOwo+IC19Cj4gLQo+IC1zdGF0aWMgdm9pZCBzaG1v Yl9kcm1fZGlzYWJsZV92Ymxhbmsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50 Cj4gcGlwZSkgLXsKPiAtCXN0cnVjdCBzaG1vYl9kcm1fZGV2aWNlICpzZGV2ID0gZGV2LT5kZXZf cHJpdmF0ZTsKPiAtCj4gLQlzaG1vYl9kcm1fY3J0Y19lbmFibGVfdmJsYW5rKHNkZXYsIGZhbHNl KTsKPiAtfQo+IC0KPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgc2htb2Jf ZHJtX2ZvcHMgPSB7Cj4gIAkub3duZXIJCT0gVEhJU19NT0RVTEUsCj4gIAkub3BlbgkJPSBkcm1f b3BlbiwKPiBAQCAtMjU2LDggKzIzOSw2IEBAIHN0YXRpYyB2b2lkIHNobW9iX2RybV9kaXNhYmxl X3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZQo+ICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKSAubG9h ZAkJCT0gc2htb2JfZHJtX2xvYWQsCj4gIAkudW5sb2FkCQkJPSBzaG1vYl9kcm1fdW5sb2FkLAo+ ICAJLmlycV9oYW5kbGVyCQk9IHNobW9iX2RybV9pcnEsCj4gLQkuZW5hYmxlX3ZibGFuawkJPSBz aG1vYl9kcm1fZW5hYmxlX3ZibGFuaywKPiAtCS5kaXNhYmxlX3ZibGFuawkJPSBzaG1vYl9kcm1f ZGlzYWJsZV92YmxhbmssCj4gIAkuZ2VtX2ZyZWVfb2JqZWN0X3VubG9ja2VkID0gZHJtX2dlbV9j bWFfZnJlZV9vYmplY3QsCj4gIAkuZ2VtX3ZtX29wcwkJPSAmZHJtX2dlbV9jbWFfdm1fb3BzLAo+ ICAJLnByaW1lX2hhbmRsZV90b19mZAk9IGRybV9nZW1fcHJpbWVfaGFuZGxlX3RvX2ZkLAoKLS0g ClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK