From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Fernandes Subject: Re: [PATCH v3] ARM: omap: edma: add suspend suspend/resume hooks Date: Wed, 9 Oct 2013 09:19:10 -0500 Message-ID: <525565DE.6060303@ti.com> References: <1380639886-9526-1-git-send-email-zonque@gmail.com> <5254DB86.4000104@ti.com>,<5254E60F.80009@ti.com> <5254F54D.7060709@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:35930 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752108Ab3JIOTx (ORCPT ); Wed, 9 Oct 2013 10:19:53 -0400 In-Reply-To: <5254F54D.7060709@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Gururaja Hebbar Cc: Daniel Mack , "linux-usb@vger.kernel.org" , "linux-omap@vger.kernel.org" , "neumann@teufel.de" , "bigeasy@linutronix.de" , "vinod.koul@intel.com" , "dan.j.williams@intel.com" , "Balbi, Felipe" On 10/09/2013 01:18 AM, Gururaja Hebbar wrote: > On Wednesday 09 October 2013 11:33 AM, Fernandes, Joel wrote: >> Some temporary issues with my mua so forgive any artifacts in this email. >> >> On Oct 9, 2013, at 12:14 AM, "Hebbar, Gururaja" wrote: >> >>> On Wednesday 09 October 2013 09:58 AM, Joel Fernandes wrote: >>>> On 10/01/2013 10:04 AM, Daniel Mack wrote: >>>>> This patch makes the edma driver resume correctly after suspend. Tested >>>>> on an AM33xx platform with cyclic audio streams. >>>>> >>>>> The code was shamelessly taken from an ancient BSP tree. >>>>> >>>>> Signed-off-by: Daniel Mack >>>>> --- >>>>> arch/arm/common/edma.c | 133 +++++++++++++++++++++++++++++++++++++++++++++++++ >>>>> 1 file changed, 133 insertions(+) >>> >>> ..snip.. >>> ..snip.. >>>> >>>>> + edma_cc[j]->context.ch_map = >>>>> + kzalloc((sizeof(unsigned int) * >>>>> + edma_cc[j]->num_channels), GFP_KERNEL); >>>>> + edma_cc[j]->context.que_num = >>>>> + kzalloc((sizeof(unsigned int) * 8), GFP_KERNEL); >>>> >>>> Can these allocations be moved to the suspend path? For systems that don't >>>> suspend/resume even once, I feel we shouldn't allocate memory that we don't use. >>>> These allocations are better to do there. >>> >>> AFAIK, Suspend/resume should be quick. Allocating and deallocating on >>> every iterating would be useless and time consuming. >> >> Nobody said allocate and deallocate on every iteration. Allocate once during the first suspend call and then don't have to allocate on subsequent calls. > > I couldn't find any code which allocates parameters inside suspend. > Could you show me some code which does this? Based on my last reply to Daniel, inorder to restore- there's no need to allocate/save anything. thanks, -Joel