From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46289)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1VTyIs-0006ir-IP
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 14:16:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1VTyIk-0004iL-GT
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 14:16:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41481)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1VTyIk-0004hY-8P
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 14:16:02 -0400
Message-ID: <52559D5A.2030408@redhat.com>
Date: Wed, 09 Oct 2013 20:15:54 +0200
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1381259403-7386-1-git-send-email-hdegoede@redhat.com>	<52545950.5070403@redhat.com>
	<52545B44.70005@redhat.com>	<28EE4224-856B-4DC1-8159-A0C274BD269E@alex.org.uk>	<52546000.6070308@redhat.com>	<6CD4D4EE-341E-48D0-98F4-D55C0D3922D4@alex.org.uk>	<52546832.9040900@redhat.com>
	<5254701B.5070804@redhat.com>	<525552D9.90407@redhat.com>	<2451DF8D-DD3E-4875-B6D6-CEF66A763D7E@alex.org.uk>
	<52559A8A.2070201@redhat.com>
In-Reply-To: <52559A8A.2070201@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads
 when main_loop_tlg has pending events
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Hi,

On 10/09/2013 08:03 PM, Hans de Goede wrote:

<snip>

> So I started looking for suspecious timers under audio/*.c and immediately
> found this in audio/audio.c :
>
> static void audio_reset_timer (AudioState *s)
> {
>      if (audio_is_timer_needed ()) {
>          timer_mod (s->ts, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + 1);
>      }
>      else {
>          timer_del (s->ts);
>      }
> }
>
> static void audio_timer (void *opaque)
> {
>      audio_run ("timer");
>      audio_reset_timer (opaque);
> }
>
> Note how that is using a timer which expires every freaking nano second,
> I think it is very likely that is the culprit.

Yep, this is the culprit, patch coming up.

Regards,

Hans