From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Maxim Uvarov <maxim.uvarov@linaro.org>
Cc: ltp-list@lists.sourceforge.net,
Maxim Uvarov <maxim.uvarov@linaro.com>,
linaro-networking@linaro.org
Subject: Re: [LTP] [PATCH] syslog-lib.sh bash posix compliance
Date: Thu, 10 Oct 2013 09:16:52 +0800 [thread overview]
Message-ID: <52560004.5060808@cn.fujitsu.com> (raw)
In-Reply-To: <1381327865-9089-1-git-send-email-maxim.uvarov@linaro.com>
On 10/09/2013 10:11 PM, Maxim Uvarov wrote:
> /opt/ltp/testcases/bin/syslog02: 69: [: syslog-ng: unexpected operator
> + [ syslog-ng == syslog-ng ]
> Accoding to:
> http://tldp.org/LDP/Bash-Beginners-Guide/html/sect_07_01.html
> [ STRING1 == STRING2 ] True if the strings are equal. "=" may be
> used instead of "==" for strict POSIX compliance.
>
> Because of busybox and other bash like shells look for posix syntax
> make it so.
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.com>
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> testcases/kernel/syscalls/syslog/syslog-lib.sh | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/syslog/syslog-lib.sh b/testcases/kernel/syscalls/syslog/syslog-lib.sh
> index 0885805..6b19b8d 100755
> --- a/testcases/kernel/syscalls/syslog/syslog-lib.sh
> +++ b/testcases/kernel/syscalls/syslog/syslog-lib.sh
> @@ -65,11 +65,11 @@ setup()
> tst_resm TBROK "Testing is terminating due to a signal"
> cleanup 1' $TRAP_SIGS || exit 1
>
> - if [ "$SYSLOG_DAEMON" == "syslog" ]; then
> + if [ "$SYSLOG_DAEMON" = "syslog" ]; then
> CONFIG_FILE="/etc/syslog.conf"
> - elif [ "$SYSLOG_DAEMON" == "syslog-ng" ]; then
> + elif [ "$SYSLOG_DAEMON" = "syslog-ng" ]; then
> CONFIG_FILE="/etc/syslog-ng/syslog-ng.conf"
> - elif [ "$SYSLOG_DAEMON" == "rsyslog" ]; then
> + elif [ "$SYSLOG_DAEMON" = "rsyslog" ]; then
> CONFIG_FILE="/etc/rsyslog.conf"
> RSYSLOG_CONFIG='$ModLoad imuxsock.so'
> else
>
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-10-10 1:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 14:11 [LTP] [PATCH] syslog-lib.sh bash posix compliance Maxim Uvarov
2013-10-10 1:16 ` Wanlong Gao [this message]
2013-10-14 5:39 ` Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2013-10-09 14:13 Maxim Uvarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52560004.5060808@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=linaro-networking@linaro.org \
--cc=ltp-list@lists.sourceforge.net \
--cc=maxim.uvarov@linaro.com \
--cc=maxim.uvarov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.